Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easystroke: init at 0.6.0-9-gf7c1614 #37353

Closed
wants to merge 2 commits into from

Conversation

@psyky
Copy link

commented Mar 19, 2018

Motivation for this change

easystroke: init at 0.6.0-9-gf7c1614

Easystroke is a X11 gesture recognition application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@psyky psyky changed the title Easystroke easystroke: init at 0.6.0-9-gf7c1614 Mar 19, 2018

@andir
Copy link
Member

left a comment

Thanks 👍

I left some comments in the review.

enableParallelBuild = true;

patches = [
(fetchpatch {

This comment has been minimized.

Copy link
@andir

andir Mar 21, 2018

Member

Can you explain why those patches are required? Did you attempt to submit them to upstream if they are an essential part of the package?

};

nativeBuildInputs = [ pkgconfig gcc7 wrapGAppsHook help2man ];
buildInputs = [ boost dbus_glib gnome3.gtkmm xorg.libXtst xorg.inputproto

This comment has been minimized.

Copy link
@andir

andir Mar 21, 2018

Member

Can you fix the indention & order here?

Sorting dependencies alphabetically and having a common indention level across all list elements is what most people seem to do. Unfortunately, there is no style guide (yet).

let
version = "0.6.0-9-gf7c1614";
in stdenv.mkDerivation {
name = "easystroke-${version}";

This comment has been minimized.

Copy link
@andir

andir Mar 21, 2018

Member

According to our naming guide (https://nixos.org/nixpkgs/manual/#sec-package-naming) the package name should probably be (final form after evaluation): easystroke-unstable-2000-01-31 (with correct date)

@@ -0,0 +1,55 @@
{ stdenv, fetchFromGitHub, fetchpatch, pkgconfig, boost, dbus_glib, gnome3,

This comment has been minimized.

Copy link
@andir

andir Mar 21, 2018

Member

Why did you specify gcc7 there (& within nativeBuildInputs)? Usually sticking with just using whatever stdenv provides is what you want.

@andir

This comment has been minimized.

Copy link
Member

commented Mar 21, 2018

@GrahamcOfBorg build easystroke

@GrahamcOfBorg

This comment has been minimized.

Copy link

commented Mar 21, 2018

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: easystroke

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg

This comment has been minimized.

Copy link

commented Mar 21, 2018

Success on x86_64-linux (full log)

Attempted: easystroke

Partial log (click to expand)

hicolorPreFixupPhase
post-installation fixup
Wrapping program /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614/bin/easystroke
shrinking RPATHs of ELF executables and libraries in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614
shrinking /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614/bin/.easystroke-wrapped
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614/bin
patching script interpreter paths in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614
checking for references to /tmp/nix-build-easystroke-0.6.0-9-gf7c1614.drv-0 in /nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614...
/nix/store/2b1xacc9n6b4s11fmdx5bg51khv03xch-easystroke-0.6.0-9-gf7c1614

@GrahamcOfBorg

This comment has been minimized.

Copy link

commented Mar 21, 2018

Failure on aarch64-linux (full log)

Attempted: easystroke

Partial log (click to expand)

   Compiling rustc_save_analysis v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_save_analysis)
   Compiling rustc_plugin v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_plugin)
building of '/nix/store/6mm6pr840z429p4l9mk62gh7mr6khj3k-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/wsycxxpy4fin6rmfmx67n1b5pdzjww20-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/byqkqqkjq1m38ikbxxrirk81d0wr4qns-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/azb669rka042skzps2bpc7m7bs1r5afm-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9m843nlahfvzxpcqhxqy1qb5cz6jwa5a-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wsgyalfxylcxbs6nlf4kd7p9cvxc1f1b-adwaita-icon-theme-3.26.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/b8si13r2gnai8zmr64bilk094xfzgrjx-easystroke-0.6.0-9-gf7c1614.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/b8si13r2gnai8zmr64bilk094xfzgrjx-easystroke-0.6.0-9-gf7c1614.drv' failed

@ivan ivan referenced this pull request Dec 17, 2018
5 of 10 tasks complete

ivan added a commit to ivan/nixpkgs that referenced this pull request Dec 17, 2018

easystroke: init at unstable-2016-07-05
This commit is based on work by Andreas Schaefer in
NixOS#37353

ivan added a commit to ivan/nixpkgs that referenced this pull request Jan 12, 2019

easystroke: init at unstable-2016-07-05
This commit is based on work by Andreas Schaefer in
NixOS#37353

ivan added a commit to ivan/nixpkgs that referenced this pull request Jan 13, 2019

easystroke: init at unstable-2016-07-05
This commit is based on work by Andreas Schaefer in
NixOS#37353

ivan added a commit to ivan/nixpkgs that referenced this pull request Jan 13, 2019

easystroke: init at unstable-2016-07-05
This commit is based on work by Andreas Schaefer in
NixOS#37353
@nixos-discourse

This comment has been minimized.

Copy link

commented Jun 27, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/26

@timokau

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

Replaced by #52424.

@timokau timokau closed this Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.