Skip to content

grafanaPlugins.victoriametrics-logs-datasource: init at 0.14.3#376400

Merged
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
wlcx:init-grafana-victoriametrics-plugin
Feb 10, 2025
Merged

grafanaPlugins.victoriametrics-logs-datasource: init at 0.14.3#376400
SuperSandro2000 merged 1 commit into
NixOS:masterfrom
wlcx:init-grafana-victoriametrics-plugin

Conversation

@wlcx

@wlcx wlcx commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

Add the victorialogs grafana datasource plugin

Things done

Tested against a 24.11 grafana install.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 24, 2025
@Shawn8901

Copy link
Copy Markdown
Contributor

VictoriaMetrics/victorialogs-datasource#214

looks like that there will be finally a signed version if i understand the PR correctly (not yet visible on the market)

I was waiting for similar for the metrics datasource.

@wlcx

wlcx commented Jan 24, 2025

Copy link
Copy Markdown
Contributor Author

3 hours ago

Wow - total coincidence that I happened to be packaging this. Ok, I'll mark this as draft and will update when it's available via the marketplace

@wlcx wlcx changed the title grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 draft: grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 Jan 25, 2025
@wlcx wlcx marked this pull request as draft January 25, 2025 23:58
@wlcx wlcx changed the title draft: grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 Jan 25, 2025
@wlcx wlcx closed this Jan 29, 2025
@wlcx wlcx reopened this Jan 29, 2025
@Shawn8901

Shawn8901 commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

Fyi https://grafana.com/grafana/plugins/victoriametrics-logs-datasource/

Logs data source has arrived at market place

@wlcx wlcx force-pushed the init-grafana-victoriametrics-plugin branch from 638fda9 to f05f29d Compare January 30, 2025 16:42
@wlcx wlcx marked this pull request as ready for review January 30, 2025 16:50
@wlcx wlcx changed the title grafanaPlugins.victoriametrics-logs-datasource: init at 0.13.4 grafanaPlugins.victoriametrics-logs-datasource: init at 0.14.3 Jan 30, 2025
@wlcx wlcx force-pushed the init-grafana-victoriametrics-plugin branch from f05f29d to 3836916 Compare January 30, 2025 16:52

@Shawn8901 Shawn8901 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside the meta suggestion, works fine, have it deployed on my grafana instance and tried some queries.

and possibly you want to update the PR text as its no longer accurate after the plugin was signed.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 1, 2025
@wlcx wlcx force-pushed the init-grafana-victoriametrics-plugin branch from 3836916 to 86a9e00 Compare February 4, 2025 20:57
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 4, 2025
@wlcx wlcx force-pushed the init-grafana-victoriametrics-plugin branch from 86a9e00 to b6ed862 Compare February 4, 2025 22:40
@wlcx

wlcx commented Feb 5, 2025

Copy link
Copy Markdown
Contributor Author

Updated, thanks

@Shawn8901 Shawn8901 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 10, 2025
@SuperSandro2000 SuperSandro2000 merged commit 8475ada into NixOS:master Feb 10, 2025
@wlcx wlcx deleted the init-grafana-victoriametrics-plugin branch February 17, 2025 11:05
@nixpkgs-ci

nixpkgs-ci Bot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-376400-to-release-24.11 origin/release-24.11
cd .worktree/backport-376400-to-release-24.11
git switch --create backport-376400-to-release-24.11
git cherry-pick -x b6ed862e65772fab57f460f5670a518b5bae0ef5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants