Merged
Conversation
github-actions
bot
added
the
6.topic: nodejs
Contributor
Author
|
I re-applied the changes I did in https://github.com/NixOS/nixpkgs/pull/351767/files over the latest master and with the latest release of elm-review, and the problem with broken package-lock.json file seems to have been resolved upstream. The package now successfully builds on my nix-darwin and nixos machines. |
13 tasks
zupo
force-pushed
the
elm-review-buildNpmPackage
branch
3 times, most recently
from
317a4aa to
691465c
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
Rewriten from node2nix to buildNpmPackage. Previous work on this started in https://github.com/NixOS/nixpkgs/pull/351767/files. Also, added a simple test. Refs Thaigersprint/thaigersprint-2025#1
zupo
force-pushed
the
elm-review-buildNpmPackage
branch
from
691465c to
23fed8e
Compare
Member
|
great news! thanks @zupo. Testing this now. |
turboMaCk
reviewed
Feb 15, 2025
| license = lib.licenses.bsd3; | ||
| maintainers = with lib.maintainers; [ | ||
| turbomack | ||
| zupo |
Member
There was a problem hiding this comment.
good to see more maintainers there 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.