From d0048bb8ee8f3ae3cee8042e11bf94e400e7de25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Tue, 18 Mar 2025 13:17:48 -0700 Subject: [PATCH] nodePackages.ijavascript: drop It fails to build with npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h: In instantiation of 'v8::Local::Local(v8::Local) [with S = v8::Data; T = v8::Value]': npm error ../../nan/nan_callbacks_12_inl.h:175:53: required from here npm error 175 | cbinfo(info, obj->GetInternalField(kDataIndex)); npm error | ^ npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h:269:42: error: static assertion failed: type check npm error 269 | static_assert(std::is_base_of::value, "type check"); npm error | ^~~~~ npm error /nix/store/bhc0grw1nwzwgh55qapfqwb3vil5s49y-node-sources/deps/v8/include/v8-local-handle.h:269:42: note: 'std::integral_constant::value' evaluates to false --- pkgs/development/node-packages/aliases.nix | 1 + .../node-packages/node-packages.json | 1 - .../node-packages/node-packages.nix | 27 ------------------- pkgs/development/node-packages/overrides.nix | 7 ----- 4 files changed, 1 insertion(+), 35 deletions(-) diff --git a/pkgs/development/node-packages/aliases.nix b/pkgs/development/node-packages/aliases.nix index c4815d06870d3..78243f424fc70 100644 --- a/pkgs/development/node-packages/aliases.nix +++ b/pkgs/development/node-packages/aliases.nix @@ -127,6 +127,7 @@ mapAliases { inherit (pkgs) http-server; # added 2024-01-20 hueadm = pkgs.hueadm; # added 2023-07-31 inherit (pkgs) hyperpotamus; # added 2023-08-19 + ijavascript = throw "ijavascript has been removed because it was broken"; # added 2025-03-18 immich = pkgs.immich-cli; # added 2023-08-19 indium = throw "indium was removed because it was broken"; # added 2023-08-19 inliner = throw "inliner was removed because it was abandoned upstream"; # added 2024-08-23 diff --git a/pkgs/development/node-packages/node-packages.json b/pkgs/development/node-packages/node-packages.json index 8bad14812407a..af7f8fd5a9b2b 100644 --- a/pkgs/development/node-packages/node-packages.json +++ b/pkgs/development/node-packages/node-packages.json @@ -93,7 +93,6 @@ , "gulp-cli" , "he" , "hs-airdrop" -, "ijavascript" , "imapnotify" , "joplin" , "js-beautify" diff --git a/pkgs/development/node-packages/node-packages.nix b/pkgs/development/node-packages/node-packages.nix index 997480177d81a..a69d9a8d6abca 100644 --- a/pkgs/development/node-packages/node-packages.nix +++ b/pkgs/development/node-packages/node-packages.nix @@ -54272,33 +54272,6 @@ in bypassCache = true; reconstructLock = true; }; - ijavascript = nodeEnv.buildNodePackage { - name = "ijavascript"; - packageName = "ijavascript"; - version = "5.2.1"; - src = fetchurl { - url = "https://registry.npmjs.org/ijavascript/-/ijavascript-5.2.1.tgz"; - sha512 = "kH7hudp+S+8++ngjUXbiyHOhp3qa4oDVUkmf6p7+7s15PIBDv5zx878pxNRdGcWhYGy5TT683EOqeKMQw8jrFA=="; - }; - dependencies = [ - sources."jmp-2.0.0" - sources."jp-kernel-2.0.0" - sources."nan-2.17.0" - sources."nel-1.3.0" - sources."node-gyp-build-4.8.4" - sources."uuid-3.4.0" - sources."zeromq-5.3.1" - ]; - buildInputs = globalBuildInputs; - meta = { - description = "IJavascript is a Javascript kernel for the Jupyter notebook"; - homepage = "https://n-riesco.github.io/ijavascript"; - license = "BSD-3-Clause"; - }; - production = true; - bypassCache = true; - reconstructLock = true; - }; imapnotify = nodeEnv.buildNodePackage { name = "imapnotify"; packageName = "imapnotify"; diff --git a/pkgs/development/node-packages/overrides.nix b/pkgs/development/node-packages/overrides.nix index 545a907cef233..373843cb7ab50 100644 --- a/pkgs/development/node-packages/overrides.nix +++ b/pkgs/development/node-packages/overrides.nix @@ -54,13 +54,6 @@ final: prev: { ''; }; - ijavascript = prev.ijavascript.override (oldAttrs: { - preRebuild = '' - export npm_config_zmq_external=true - ''; - buildInputs = oldAttrs.buildInputs ++ [ final.node-gyp-build pkgs.zeromq ]; - }); - joplin = prev.joplin.override (oldAttrs:{ nativeBuildInputs = [ pkgs.pkg-config