postgresqlPackages.timescaledb_toolkit: run post-install script - #413622
Conversation
|
Please rebase to trigger the flaky CI again and change the commit's prefix according to the PR title change I made. This will make ofborg pick up the right package to build and test. A general question: Is this post-install script to generate the migration script a timescaledb_toolkit specific thing - or is this something that all cargo-pgrx extensions need to do? If the latter, we need to change it in |
99207e4 to
4183008
Compare
|
|
Thank you! |
|
bisect shows that this breaks |
|
Just came to the same conclusion without bisecting ;) It seems like after this change the Not sure whether loading this as a shared_preload_library ever made sense. |
|
Seems like loading this as shared_preload has been introduced in #186276, but I can't find any discussion about that. Probably wasn't needed from the start, so I'd say we just remove that. We still do |
Currently users of the
postgresXXPackages.timescaledb_toolkitpackage can't update the extension (without dropping/creating it). This is because Toolkit has a post-install script that creates the update scripts, which isn't currently being run. This PR makes nixpkgs run Toolkit's post-install script.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.