Skip to content

Fix rWrapper on darwin #41606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2018
Merged

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should fix the rWrapper derivation on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

knedlsepp added 5 commits June 6, 2018 23:57
This fixes the error:
    ld: library not found for -liconv
This fixes the error:
    ld: library not found for -liconv
This fixes the error:
    ld: library not found for -liconv
This fixes the error:
    ld: library not found for -liconv
This fixes the error:
    ld: library not found for -liconv
@knedlsepp knedlsepp requested a review from peti as a code owner June 6, 2018 22:03
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jun 6, 2018
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build rWrapper

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rWrapper

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rWrapper

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wjcrchq37cm9dgms8lg6iyspigbn4m68-R-3.5.0-wrapper
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wjcrchq37cm9dgms8lg6iyspigbn4m68-R-3.5.0-wrapper/bin
patching script interpreter paths in /nix/store/wjcrchq37cm9dgms8lg6iyspigbn4m68-R-3.5.0-wrapper
checking for references to /build in /nix/store/wjcrchq37cm9dgms8lg6iyspigbn4m68-R-3.5.0-wrapper...
/nix/store/wjcrchq37cm9dgms8lg6iyspigbn4m68-R-3.5.0-wrapper

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 6, 2018
@matthewbauer matthewbauer merged commit f5b0d6d into NixOS:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants