hiawatha: GitHub -> GitLab, clean-up #41653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Calling package maintainer: @ndowens |
GrahamcOfBorg
added
10.rebuild-darwin: 0
jtojnar
reviewed
Jun 8, 2018
| }; | ||
|
|
||
| buildInputs = [ cmake libxslt zlib libxml2 ] ++ stdenv.lib.optional enableSSL openssl ; | ||
| buildInputs = [ cmake ninja libxslt libxml2 ]; |
There was a problem hiding this comment.
At least cmake and ninja should go to nativeBuildInputs.
Developer deleted account on GitHub. As a GitLab proof - official page: https://www.hiawatha-webserver.org/download points to GitLab. * Web server officially created for mbedtls, use bundled * Assert not needed * Build with cmake/ninja * Removed hack, no longer needed
|
We should probably add those flags and build this with |
|
Do make this flags: default in Seems like a reasonable thing.
|
|
Sounds good to me. Enabling test suite is also always good if it is not too much hassle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer deleted account on GitHub. As a GitLab proof - official page:
https://www.hiawatha-webserver.org/download
points to GitLab.
mbedtls, so use bundledMotivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)