Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force positive stackprotector detection on x64 for Linux >=4.16 #42362

Closed
wants to merge 1 commit into from

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Jun 22, 2018

The stackprotector is not detected correctly when during out-of-kernel compilations, breaking ZFS under >=4.16.

Motivation for this change

Fixes #39225

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • nix-build -A stable zfs.nix for kernelPackage forced to pkgs.linuxPackages_4_16 and pkgs.linuxPackages_4_17.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

The stackprotector is not detected correctly when during out-of-kernel
compilations, breaking ZFS under >=4.16.
@clefru
Copy link
Contributor Author

clefru commented Jun 23, 2018

I have a better fix than this.

@clefru clefru closed this Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants