Skip to content

contact: init at 1.3.16 - #427048

Merged
numinit merged 1 commit into
NixOS:masterfrom
sarcasticadmin:rh/1752030801
Aug 8, 2025
Merged

contact: init at 1.3.16#427048
numinit merged 1 commit into
NixOS:masterfrom
sarcasticadmin:rh/1752030801

Conversation

@sarcasticadmin

@sarcasticadmin sarcasticadmin commented Jul 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

These changes were tested using SenseCAP Indicator (2.7.0.705515a) meshtastic hardware over a serial connection.

Additional context around the upstream issue can be found here: pdxlocations/contact#203

Utilizing unstable to include fix for writing user config to $HOME instead of scripts parent dir (/nix/store/ in our case): pdxlocations/contact#208

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

iamanaws
iamanaws reviewed Jul 21, 2025
View reviewed changes
Comment thread pkgs/by-name/co/contact/package.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 21, 2025
@sarcasticadmin
sarcasticadmin force-pushed the rh/1752030801 branch 2 times, most recently from c722f36 to 0c9de02 Compare July 21, 2025 16:31
@sarcasticadmin sarcasticadmin changed the title contact: init at 1.3.15-unstable-2025-07-18 contact: init at 1.3.16 Jul 21, 2025
RossSmyth
RossSmyth reviewed Jul 21, 2025
View reviewed changes
Comment thread pkgs/by-name/co/contact/package.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 22, 2025
iamanaws
iamanaws reviewed Jul 22, 2025
View reviewed changes
Comment thread pkgs/by-name/co/contact/package.nix Outdated
Comment thread pkgs/by-name/co/contact/package.nix Outdated
@sarcasticadmin
sarcasticadmin requested a review from iamanaws July 24, 2025 16:10
iamanaws
iamanaws approved these changes Jul 25, 2025
View reviewed changes

@iamanaws iamanaws left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jul 25, 2025
iamanaws
iamanaws reviewed Jul 31, 2025
View reviewed changes
Comment thread pkgs/by-name/co/contact/package.nix Outdated
@iamanaws

iamanaws commented Aug 2, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 427048

Logs: https://github.com/Iamanaws/nixpkgs-review-gha/actions/runs/16697911277

x86_64-linux

✅ 2 packages built:
  • contact
  • contact.dist

aarch64-linux

✅ 2 packages built:
  • contact
  • contact.dist

@numinit
numinit merged commit 94f888b into NixOS:master Aug 8, 2025
25 of 27 checks passed
@numinit

numinit commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

For posterity (hello #441048) 🙋 this one was merged onstage at Nix Vegas and announced over Meshtastic 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@numinit numinit numinit approved these changes
+2 more reviewers
@iamanaws iamanaws iamanaws approved these changes
@RossSmyth RossSmyth RossSmyth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sarcasticadmin @iamanaws @numinit @RossSmyth