Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dRonin: init at 2018-06-30. breakpad: init at 2018-07-06 #43572

Closed
wants to merge 2 commits into from

Conversation

@expipiplus1
Copy link
Contributor

expipiplus1 commented Jul 15, 2018

No description provided.

expipiplus1 added 2 commits Jul 8, 2018
This reverts commit 8bd10a1 and updates
breakpad sources.
@expipiplus1

This comment has been minimized.

Copy link
Contributor Author

expipiplus1 commented Jul 15, 2018

supersedes #28018

@expipiplus1

This comment has been minimized.

Copy link
Contributor Author

expipiplus1 commented Jul 15, 2018

Doesn't build on master due to qt creator failing to build.

Copy link
Member

thoughtpolice left a comment

Minor nit. We could at least take the breakpad change first, provided it all builds.

chmod +w -R src/third_party/lss
'';

meta = {

This comment has been minimized.

Copy link
@thoughtpolice

thoughtpolice Jul 19, 2018

Member

The rest of meta should be filled out.

in

stdenv_multi.mkDerivation rec {
name = "dRonin-${version}";
@@ -15664,6 +15666,8 @@ with pkgs;
inherit (gnome3) gtksourceview;
};

dronin = callPackage ../applications/science/robotics/dronin { };

This comment has been minimized.

Copy link
@samueldr

samueldr Nov 11, 2018

Member

This will need to be fixed, see c327df5 and aa4707f

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented May 16, 2019

@expipiplus1 are you able to address the requested changes and continue with this PR?

@expipiplus1

This comment has been minimized.

Copy link
Contributor Author

expipiplus1 commented Sep 3, 2019

sorry, @aanderse I'm not able to continue this at the moment.

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Sep 3, 2019

@expipiplus1 sure, no problem. I'm going to close the PR for now, but if you decide to pick this up again in the future please feel free to open it.

@aanderse aanderse closed this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.