[DO NOT MERGE] teamviewer service: fix PID file warning #44764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teamviewer startup script doesn't support changing of PIDFile, it manages it's PIDFile in `/var/run/teamviewerd.pid`. This confuses systemd (services claims to be started but it haven't created `/run/teamviewerd.pid`). Systemd fixes this on it's own by creating second PID file in `/run/teamviewerd.pid`. If someone wants to patch teamviewer startup scripts instead - we warned, it's a mess not worth bothering... Fixes NixOS#44307
GrahamcOfBorg
added
6.topic: nixos
coretemp
approved these changes
Aug 8, 2018
GrahamcOfBorg
added
10.rebuild-darwin: 0
danbst
changed the title
|
Actually, after more testing I found that sometimes service can't be started after this change. |
|
Not 100% sure if this would work, but: what about using |
|
no, I've overestimated my skills of debugging teamviewer. @andrew-d you may try that in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teamviewer startup script doesn't support changing of PIDFile, it manages it's PIDFile in
/var/run/teamviewerd.pid. This confuses systemd (services claims to be started but it haven't created/run/teamviewerd.pid). Systemd fixes this on it's own by creating second PID file in/run/teamviewerd.pid.If someone wants to patch teamviewer startup scripts instead - we warned, it's a mess not worth bothering...
Fixes #44307
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)