Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefitool: init at 0.25.1 #45963

Closed
wants to merge 1 commit into from
Closed

uefitool: init at 0.25.1 #45963

wants to merge 1 commit into from

Conversation

@tadfisher
Copy link
Contributor

@tadfisher tadfisher commented Sep 2, 2018

Motivation for this change

Add the UEFITool application for examining and modifying UEFI firmware images.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

@GrahamcOfBorg GrahamcOfBorg commented Sep 2, 2018

Success on x86_64-linux (full log)

Attempted: uefitool

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1
shrinking /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin/UEFIPatch
shrinking /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin/UEFIReplace
shrinking /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin/UEFITool
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin
patching script interpreter paths in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1
checking for references to /build in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1...
postPatchMkspecs
/nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1

@GrahamcOfBorg
Copy link

@GrahamcOfBorg GrahamcOfBorg commented Sep 2, 2018

Success on aarch64-linux (full log)

Attempted: uefitool

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1
shrinking /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin/UEFIReplace
shrinking /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin/UEFIPatch
shrinking /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin/UEFITool
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin
patching script interpreter paths in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1
checking for references to /build in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1...
postPatchMkspecs
/nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1

@xeji
Copy link
Contributor

@xeji xeji commented Sep 3, 2018

let's check the darwin build
@GrahamcOfBorg build uefitool

@GrahamcOfBorg
Copy link

@GrahamcOfBorg GrahamcOfBorg commented Sep 3, 2018

Success on aarch64-linux (full log)

Attempted: uefitool

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1
shrinking /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin/UEFIReplace
shrinking /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin/UEFIPatch
shrinking /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin/UEFITool
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1/bin
patching script interpreter paths in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1
checking for references to /build in /nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1...
postPatchMkspecs
/nix/store/57y410c2q62ix6dvm3m8algjj26f9hli-UEFITool-0.25.1

@GrahamcOfBorg
Copy link

@GrahamcOfBorg GrahamcOfBorg commented Sep 3, 2018

Success on x86_64-linux (full log)

Attempted: uefitool

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1
shrinking /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin/UEFITool
shrinking /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin/UEFIReplace
shrinking /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin/UEFIPatch
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1/bin
patching script interpreter paths in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1
checking for references to /build in /nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1...
postPatchMkspecs
/nix/store/9s8s41w4q0p29z35hd8s47qvcvp2szfm-UEFITool-0.25.1

@GrahamcOfBorg
Copy link

@GrahamcOfBorg GrahamcOfBorg commented Sep 3, 2018

Failure on x86_64-darwin (full log)

Attempted: uefitool

Partial log (click to expand)

Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile.uefitool:226: UEFITool.app/Contents/MacOS/UEFITool] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-UEFITool-0.25.1.drv-0/UEFITool-0.25.1'
make: *** [Makefile:44: sub-uefitool-pro-make_first] Error 2
builder for '/nix/store/dh5fhyxhaab2p5pbpp63nc8sv5d0d1a1-UEFITool-0.25.1.drv' failed with exit code 2
error: build of '/nix/store/dh5fhyxhaab2p5pbpp63nc8sv5d0d1a1-UEFITool-0.25.1.drv' failed

@xeji
Copy link
Contributor

@xeji xeji commented Sep 3, 2018

looks like this is not intended for darwin. Please change platforms to platforms.linux to exclude darwin.

name = "UEFITool-${version}";
version = "0.25.1";

src = fetchurl {

This comment has been minimized.

@yegortimoshenko

yegortimoshenko Oct 13, 2018
Member

This should be a fetchzip.

This comment has been minimized.

@Ekleog

Ekleog Nov 1, 2018
Member

… wait, why? it's a download for a .tar.gz

This comment has been minimized.

@yegortimoshenko

yegortimoshenko Nov 1, 2018
Member

fetchzip is for any archive, not just ZIP. GitHub may (and sometimes does) recompress revision archives, so this will break unless we checksum contents rather than archive itself.

This comment has been minimized.

@Ekleog

Ekleog Nov 1, 2018
Member

In exchange it adds an unneeded dependency to zip… right?

Regardless, I think this should be fetchFromGitHub :)

This comment has been minimized.

This comment has been minimized.

@Ekleog

Ekleog Nov 1, 2018
Member

Yes. Doesn't mean it's not semantically the correct one, esp. when downloading a .tar.gz :)

This comment has been minimized.

@yegortimoshenko

yegortimoshenko Nov 1, 2018
Member

That's controversial and still up to debate. I actually prefer fetchTarball/fetchzip style interface over fetchFromGitHub. I agree fetchzip should be renamed.

See #32997 (comment), #27327 (comment), #32997 (comment).

@Ekleog
Copy link
Member

@Ekleog Ekleog commented Nov 1, 2018

(triage) @tadfisher, are you still interested in moving this forward?

@tadfisher
Copy link
Contributor Author

@tadfisher tadfisher commented Nov 1, 2018

@Ekleog I am, but I don't have a Mac to test with. This should compile for darwin, but I don't know how to make that work without hardware to test on. Should I mark this Linux-only or just broken on darwin?

@xeji
Copy link
Contributor

@xeji xeji commented Nov 1, 2018

Should I mark this Linux-only or just broken on darwin?

Please mark it broken on darwin: darwin is supported upstream (they distribute Mac binaries) but doesn't currently build in nixpkgs.

Copy link
Member

@ryantm ryantm left a comment

"Please mark it broken on darwin"

@ajs124 ajs124 mentioned this pull request Mar 15, 2019
4 of 10 tasks complete
@ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 6, 2020

This can probably be closed, now that #57034 is merged.

@ryantm ryantm closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.