Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-artwork: Keeps new wallpaper compatible with old path. #46074

Closed
wants to merge 1 commit into from

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Sep 5, 2018

See:

cc @grahamc

This will need a backport to 18.09 too.

Things done

I have only verified the contents of result after a nix-build

~/tmp/nixpkgs/nixpkgs $ ls -l result/share/artwork/gnome/
lrwxrwxrwx 1 root root 133 Dec 31  1969 result/share/artwork/gnome/Gnome_Dark.png -> /nix/store/gzy4psym7619fdjz11ywlllaxfjhzmdl-simple-dark-gray-2018-08-28/share/artwork/gnome/nix-wallpaper-simple-dark-gray_bottom.png
lrwxrwxrwx 1 root root  85 Dec 31  1969 result/share/artwork/gnome/nix-wallpaper-simple-dark-gray_bottom.png -> /nix/store/qb82wpjaf3j6pswhk73rkcd43si2nb1w-nix-wallpaper-simple-dark-gray_bottom.png

It is as expected. The symlinks are fine.


samueldr referenced this issue Sep 5, 2018
The wallpaper used is *structurally compatible* with the other one,
meaning that the logo is at the same location, and not bigger.

It has one drawback: the logo is brighter, which clashes with the grub
usage. This is to be fixed with new options in grub.
@@ -1,7 +1,7 @@
{ stdenv, fetchurl }:

let
mkNixBackground = { name, src, description }:
mkNixBackground = { name, src, description, installPhase ? "" }:
Copy link
Member Author

@samueldr samueldr Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% confident in the cleanliness of this approach, but does work. Any alternatives?

Copy link
Member

@Mic92 Mic92 Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is ok. Alterantives would be overrideAttrs or adding runHook postInstall in installPhase and inheriting postInstall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants