Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: sound: warn about changes to defaults #46490

Closed
wants to merge 1 commit into from

Conversation

@oxij
Copy link
Contributor

@oxij oxij commented Sep 10, 2018

Motivation for this change

I still think that change needs to be reverted, but if there's no will for that let's at the very least warn users about the problem that change introduced. Without this most ALSA users switching from releases before 18.03 will get sound, but won't get ALSA state save/restore. That would be very confusing.

All modules and tests that want to be completely headless disable this option explicitly. I.e. you won't see this warning unless you are affected.

Things done
  • Tested to work as expected.

Please backport to 18.09.

I still think that change needs to be reverted, but if there's no will
for that let's at the very least warn users about the problem that change
introduced. Without this most ALSA users switching from releases
before 18.03 will get sound, but won't get ALSA state save/restore.
That would be very confusing.

All modules and tests that want to be completely headless disable this
option explicitly. I.e. you won't see this warning unless you are
affected.
@oxij oxij force-pushed the nixos/alsa-default branch from d8791ba to 26934c3 Sep 10, 2018
@oxij
Copy link
Contributor Author

@oxij oxij commented Sep 10, 2018

Edit: turns out the brokenness was already included into 18.03 =/ Should I make a PR for 18.03 too?

@oxij
Copy link
Contributor Author

@oxij oxij commented Sep 10, 2018

And then I did: #46491.

warnings = optional (options.sound.enable.highestPrio > 1000) ''
You don't have `sound.enable` explicitly enabled of disabled. It was
enabled by default before a43e33d0e48b2284ac3a2222d7f1965cef66f5e2 and
became disabled by default after e349ccc77febd45abbd14be14f7de123ec4a4da2.
Copy link
Member

@edolstra edolstra Sep 10, 2018

There is no point in including commit hashes in warnings.

Copy link
Contributor Author

@oxij oxij Sep 11, 2018

I'm open to better suggestions. I don't like being vague like "some commit before 18.03" (which was another option I could come up with) when I can just give the hash (I like doing git show on random hashes I see mentioned in random PRs and comments), but I won't argue against writing whatever else you want if that gets the message across.

@oxij
Copy link
Contributor Author

@oxij oxij commented Sep 23, 2018

ping?

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 9, 2019

Any updates on this pull request, please?

@stale
Copy link

@stale stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale label Jun 1, 2020
@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 25, 2020

It looks like this was relevant to 18.03 / 18.09, which was a long time ago. Feel free to re-open if still relevant.

@bhipple bhipple closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants