New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DappHub projects #47279

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
5 participants
@asymmetric
Copy link
Contributor

asymmetric commented Sep 24, 2018

Motivation for this change

DappHub maintains a separate overlay at
https://github.com/dapphub/dapptools/blob/master/overlay.nix.

Closes #45696.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@asymmetric asymmetric force-pushed the asymmetric:asymmetric/remove-dapptools branch 3 times, most recently Sep 24, 2018

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Sep 24, 2018

cc @dbrock

@xeji

This comment has been minimized.

Copy link
Contributor

xeji commented Sep 24, 2018

This should be backported to 18.09.

@asymmetric asymmetric force-pushed the asymmetric:asymmetric/remove-dapptools branch to 6017c6f Sep 24, 2018

@Mic92 Mic92 merged commit d123b30 into NixOS:master Sep 24, 2018

8 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Sep 24, 2018

backport: 71fd97d

@asymmetric asymmetric deleted the asymmetric:asymmetric/remove-dapptools branch Sep 24, 2018

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Jan 10, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/the-cache-is-down-not-anymore/1720/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment