Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare-cli: init v3.2.0 #48030

Closed
wants to merge 1 commit into from
Closed

Conversation

@colemickens
Copy link
Member

@colemickens colemickens commented Oct 8, 2018

Motivation for this change

Add cfcli (cloudflare-cli)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@@ -1872,7 +1872,7 @@ let
packageName = "strip-ansi";
version = "3.0.1";
src = fetchurl {
url = "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";
url = "http://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";

This comment has been minimized.

@c0bw3b

c0bw3b Oct 8, 2018
Contributor

I'm not versed in Node packaging but this feels unnecessary.

@@ -1872,7 +1872,7 @@ let
packageName = "strip-ansi";
version = "3.0.1";
src = fetchurl {
url = "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";
url = "http://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";

This comment has been minimized.

@c0bw3b

c0bw3b Oct 8, 2018
Contributor

Same here.

@colemickens
Copy link
Member Author

@colemickens colemickens commented Oct 9, 2018

Thank you for the review @c0bw3b. I tend not to edit things that have been auto-generated (in this case, the *.nix are generated with generate.sh in the same directory.

But, obviously I don't think the cases you've found are good changes.

@svanderburg Can you weigh in on this? Is there a reason that these would be getting switched to http rather than https? Should I manually undo those changes and leave them as HTTPS? Is there an upstream issue for node2nix that covers this case?

Thanks all.

@@ -4392,7 +4401,7 @@ let
packageName = "bl";
version = "0.8.2";
src = fetchurl {
url = "https://registry.npmjs.org/bl/-/bl-0.8.2.tgz";
url = "http://registry.npmjs.org/bl/-/bl-0.8.2.tgz";

This comment has been minimized.

@colemickens

colemickens Oct 13, 2018
Author Member

and here

@@ -4401,7 +4410,7 @@ let
packageName = "bl";
version = "1.0.3";
src = fetchurl {
url = "https://registry.npmjs.org/bl/-/bl-1.0.3.tgz";
url = "http://registry.npmjs.org/bl/-/bl-1.0.3.tgz";

This comment has been minimized.

@colemickens

colemickens Oct 13, 2018
Author Member

and here... (and a number after this too.)

@colemickens
Copy link
Member Author

@colemickens colemickens commented Nov 1, 2018

NOTE to self: per this NixCon talk (https://youtu.be/vv4d42vbICw?t=41m7s) consider using pnpm2nix: https://github.com/adisbladis/pnpm2nix

@colemickens
Copy link
Member Author

@colemickens colemickens commented Dec 9, 2019

I don't use this, don't want to maintain it, it doesn't merge, etc. Closing...

@colemickens colemickens closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.