New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pidgin-opensteamworks: 1.6.1 -> git-2018-08-02 #48102

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Shados
Contributor

Shados commented Oct 9, 2018

Motivation for this change

I've been somewhat hesitant to update this because there haven't been any actual releases after 1.6.1, but there have been a few relevant fixes and additions in the three years since then, so to git versions we go...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Shados

This comment has been minimized.

Show comment
Hide comment
@Shados

Shados Oct 10, 2018

Contributor

@c0bw3b Sure, I've gone and fixed that. Although I suspect the intention is more about version names being independent from the chosen SVC; grep -RP 'git-(?:\d|\$)' ~/nixpkgs/ isn't a very complicated pattern, and gives only a handful of false positives. On that note: it looks like there's 100-ish packages using git-${somedate}, might be a good idea for someone to do a cleanup PR to change those over.

Contributor

Shados commented Oct 10, 2018

@c0bw3b Sure, I've gone and fixed that. Although I suspect the intention is more about version names being independent from the chosen SVC; grep -RP 'git-(?:\d|\$)' ~/nixpkgs/ isn't a very complicated pattern, and gives only a handful of false positives. On that note: it looks like there's 100-ish packages using git-${somedate}, might be a good idea for someone to do a cleanup PR to change those over.

@c0bw3b

c0bw3b approved these changes Oct 10, 2018

@c0bw3b

This comment has been minimized.

Show comment
Hide comment
@c0bw3b

c0bw3b Oct 10, 2018

Contributor

Yes I also noticed the git-date naming scheme had been used quite a lot already.. :/

Contributor

c0bw3b commented Oct 10, 2018

Yes I also noticed the git-date naming scheme had been used quite a lot already.. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment