New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fs: 0.5.4 -> 2.1.1 refactor move to python-modules #48171

Merged
merged 3 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@costrouc
Contributor

costrouc commented Oct 10, 2018

Motivation for this change

#48034 .

Things done

pythonPackages.backports_os: init at 0.1.1

pythonPackages.pyftpdlib: init at 1.5.4

pythonPackages.fs: 0.5.4 -> 2.1.1 refactor move to python-modules

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner Oct 10, 2018

@costrouc costrouc changed the title from [WIP] pythonPackages.fs: 0.5.4 -> 2.1.1 refactor move to python-modules to pythonPackages.fs: 0.5.4 -> 2.1.1 refactor move to python-modules Oct 10, 2018

Show resolved Hide resolved pkgs/development/python-modules/fs/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/fs/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/pyftpdlib/default.nix Outdated

costrouc added some commits Oct 10, 2018

@costrouc

This comment has been minimized.

Contributor

costrouc commented Oct 14, 2018

Requested changes have been made. Yes LC_ALL and glibcLocales did fix 36/40 of the tests. Ready for merge.

@costrouc

This comment has been minimized.

Contributor

costrouc commented Oct 15, 2018

@GrahamcOfBorg build python3Packages.fs python2Packages.fs

@GrahamcOfBorg

This comment has been minimized.

GrahamcOfBorg commented Oct 15, 2018

Success on x86_64-linux (full log)

Attempted: python3Packages.fs, python2Packages.fs

Partial log (click to expand)


OK (skipped=97)
Check validatepath returns an absolute path. ... ok

----------------------------------------------------------------------
Ran 1495 tests in 100.920s

OK (skipped=25)
/nix/store/r4cqd92sh62yc14j8inwiw5j6dcn0mpy-python3.6-fs-2.1.1
/nix/store/l2k0d09i1b6n040pkkmzgxhvqmlp45bw-python2.7-fs-2.1.1

@GrahamcOfBorg

This comment has been minimized.

GrahamcOfBorg commented Oct 15, 2018

Timed out, unknown build status on aarch64-linux (full log)

Attempted: python3Packages.fs, python2Packages.fs

Partial log (click to expand)


----------------------------------------------------------------------
Ran 764 tests in 24.257s

FAILED (failures=6, errors=344, skipped=55)
building of '/nix/store/kl0p49db2dspl4blr2il1ya7aycqjz7w-python2.7-pyftpdlib-1.5.4.drv' timed out after 3600 seconds
building of '/nix/store/pvgmwhf0h6aqcmhl5kg1wp2b6csfib3n-python3.6-pyftpdlib-1.5.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/c5zwn1qizd5g72hvyclw7381i43pqx13-python2.7-fs-2.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j4p741sl4zf7mk286qg85dn0zfhrffq5-python3.6-fs-2.1.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/c5zwn1qizd5g72hvyclw7381i43pqx13-python2.7-fs-2.1.1.drv', '/nix/store/j4p741sl4zf7mk286qg85dn0zfhrffq5-python3.6-fs-2.1.1.drv' failed

@FRidh FRidh merged commit c2c39a2 into NixOS:master Oct 17, 2018

8 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment