Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam: refactor steam-runtime #49420

Closed
wants to merge 2 commits into from

Conversation

@Synthetica9
Copy link
Contributor

Synthetica9 commented Oct 29, 2018

Overview of changes:

  • Use JSON instead of Nix for runtime-generated. The fetching of sources
    is done in runtime.nix.
  • runtime-generated now only specifies a path within the steamrt mirror,
    instead of the full url.
  • Automatically update the version (date) of steam-runtime.
  • Add a version to steam-runtime-wrapped.
  • Remove runtime-mirror.nix. There was no reference anywhere in nixpkgs.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 29, 2018

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: steam

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg

This comment has been minimized.

Copy link

GrahamcOfBorg commented Oct 29, 2018

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: steam

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.


@Synthetica9

This comment has been minimized.

Copy link
Contributor Author

Synthetica9 commented Oct 30, 2018

Overview of changes:

- Use JSON instead of Nix for runtime-generated. The fetching of sources
  is done in runtime.nix.
- runtime-generated now only specifies a path within the steamrt mirror,
  instead of the full url.
- Automatically update the version (date) of steam-runtime.
- Add a version to steam-runtime-wrapped.
- Remove runtime-mirror.nix. There was no reference anywhere in nixpkgs.
@Synthetica9 Synthetica9 force-pushed the Synthetica9:steamRuntimeRefactor branch to 2f3791e Dec 4, 2018
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Dec 4, 2018

@hrdinka @abbradar are you ok to merge this as maintainers?
Seems ready to me.

@Synthetica9 Synthetica9 mentioned this pull request Dec 10, 2018
3 of 10 tasks complete
@mmahut

This comment has been minimized.

Copy link
Member

mmahut commented Aug 12, 2019

Are there any updates on this pull request, please?

@Infinisil

This comment has been minimized.

Copy link
Member

Infinisil commented Jan 15, 2020

No activity in over a year, closing for now

@Infinisil Infinisil closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.