Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isso: 0.10.6 -> 0.11.1 #50310

Merged
merged 1 commit into from Nov 13, 2018
Merged

isso: 0.10.6 -> 0.11.1 #50310

merged 1 commit into from Nov 13, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Nov 13, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: isso

Partial log (click to expand)

warning: no files found matching 'isso/js/embed.dev.js'
warning: no files found matching 'isso/js/count.min.js'
warning: no files found matching 'isso/js/count.dev.js'
writing manifest file 'isso.egg-info/SOURCES.txt'
...........................................................S............
----------------------------------------------------------------------
Ran 72 tests in 7.014s

OK (SKIP=1)
/nix/store/82p8habarsr6ar3rjakrgdwla116i2c9-isso-0.11.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: isso

Partial log (click to expand)

warning: no files found matching 'isso/js/embed.dev.js'
warning: no files found matching 'isso/js/count.min.js'
warning: no files found matching 'isso/js/count.dev.js'
writing manifest file 'isso.egg-info/SOURCES.txt'
...........................................................S............
----------------------------------------------------------------------
Ran 72 tests in 10.784s

OK (SKIP=1)
/nix/store/8500m52g2rhfkqcx2jb7mjnbzhjz9s30-isso-0.11.1

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit ab4b745 into NixOS:master Nov 13, 2018
@fgaz fgaz deleted the isso/0.11.1 branch May 11, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants