New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nix-daemon: default to build with all cores available #50440

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
4 participants
@Mic92
Contributor

Mic92 commented Nov 16, 2018

These days build systems are more robust w.r.t. to concurrency.
Most users will have at least two cores in their machines.
Therefore I suggest to increase the number of cores used for building.

fixes #50376

@@ -117,7 +117,7 @@ in
buildCores = mkOption {
type = types.int;
default = 1;
default = 0;
example = 64;
description = ''
This option defines the maximum number of concurrent tasks during

This comment has been minimized.

@orivej

orivej Nov 16, 2018

Contributor

"The default is 1."

Please update this.

This comment has been minimized.

@Mic92

Mic92 Nov 16, 2018

Contributor

Dropped it since, it was redundant with the displayed default value.

nixos/nix-daemon: default to build with all cores available
These days build systems are more robust w.r.t. to concurrency.
Most users will have at least two cores in their machines.
Therefore I suggest to increase the number of cores used for building.

fixes #50376

@Mic92 Mic92 force-pushed the Mic92:nix-cores branch from fe8db40 to ced57f7 Nov 16, 2018

@orivej-nixos orivej-nixos requested a review from edolstra Nov 16, 2018

@edolstra edolstra merged commit 5835b27 into NixOS:master Nov 16, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@Mic92 Mic92 deleted the Mic92:nix-cores branch Nov 16, 2018

@Mic92 Mic92 referenced this pull request Nov 16, 2018

Merged

Call for Content: 2018/13 #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment