Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRustfmt: 0.9.0 -> 0.99.5 #50960
Conversation
This comment has been minimized.
This comment has been minimized.
Ah and I forgot to mention: I know that 1.0 is released, but our rustc is not nightly enough to build this version. I packaged the latest version I could. |
This comment has been minimized.
This comment has been minimized.
The ofborg failure seems unrelated. Is master broken ? |
This comment has been minimized.
This comment has been minimized.
@GrahamcOfBorg build rust-bindgen |
This comment has been minimized.
This comment has been minimized.
GrahamcOfBorg
commented
Nov 23, 2018
Failure on x86_64-darwin (full log) Attempted: rust-bindgen Partial log (click to expand)
|
This comment has been minimized.
This comment has been minimized.
GrahamcOfBorg
commented
Nov 23, 2018
Failure on x86_64-linux (full log) Attempted: rust-bindgen Partial log (click to expand)
|
This comment has been minimized.
This comment has been minimized.
(typo in your commit short message - @GrahamcOfBorg eval |
This comment has been minimized.
This comment has been minimized.
GrahamcOfBorg
commented
Nov 23, 2018
Failure on aarch64-linux (full log) Attempted: rust-bindgen Partial log (click to expand)
|
symphorien
force-pushed the
symphorien:rustfmt
branch
Nov 23, 2018
symphorien
requested review from
Ericson2314
and
matthewbauer
as
code owners
Nov 23, 2018
symphorien
force-pushed the
symphorien:rustfmt
branch
Nov 23, 2018
symphorien
added some commits
Nov 23, 2018
symphorien
force-pushed the
symphorien:rustfmt
branch
to
1d63496
Nov 23, 2018
This comment has been minimized.
This comment has been minimized.
Sorry for the spurious review, I messed up my rebase.
|
This comment has been minimized.
This comment has been minimized.
@GrahamcOfBorg build rust-bindgen |
This comment has been minimized.
This comment has been minimized.
GrahamcOfBorg
commented
Nov 24, 2018
Success on x86_64-linux (full log) Attempted: rust-bindgen Partial log (click to expand)
|
This comment has been minimized.
This comment has been minimized.
GrahamcOfBorg
commented
Nov 24, 2018
Failure on x86_64-darwin (full log) Attempted: rust-bindgen Partial log (click to expand)
|
This comment has been minimized.
This comment has been minimized.
GrahamcOfBorg
commented
Nov 24, 2018
Success on aarch64-linux (full log) Attempted: rust-bindgen Partial log (click to expand)
|
This comment has been minimized.
This comment has been minimized.
The rust error is hopefully fixed, when we merge: #50876 |
This comment has been minimized.
This comment has been minimized.
Merged, thanks. |
symphorien commentedNov 23, 2018
Motivation for this change
the current version of rustfmt is unable to parse code accepted by our current version of rustc.
Also enable tests in
rustc-bindgen
(they were disabled because our version of rustfmt was too old)cc @Ralith and @globin as maintainers.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
): testedcargo fmt
andrustfmt
nix path-info -S
before and after)