Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winePackages.wine: add SDL support #51214

Merged
merged 1 commit into from Dec 7, 2018
Merged

winePackages.wine: add SDL support #51214

merged 1 commit into from Dec 7, 2018

Conversation

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 29, 2018

Motivation for this change

To build the SDL driver for game controllers that has been present but disabled at compile time since wine 3.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (I tested wineWow 3.20 unstable and staging)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Dec 7, 2018

@GrahamcOfBorg build winePackages.stable wine

Copy link
Member

alyssais left a comment

Seems reasonable

@alyssais alyssais merged commit 0e8e02e into NixOS:master Dec 7, 2018
12 checks passed
12 checks passed
nix-build -A wine -A winePackages.stable --argstr system aarch64-linux Build Results
Details
nix-build -A wine -A winePackages.stable --argstr system x86_64-darwin Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A wine -A winePackages.stable --argstr system x86_64-linux Build Results
Details
@rnhmjoj

This comment has been minimized.

Copy link
Contributor Author

rnhmjoj commented Dec 8, 2018

Thank you

@rnhmjoj rnhmjoj deleted the rnhmjoj:wine branch Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.