Skip to content

cht-sh: init at unstable-2018-11-02 #51236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Nov 29, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 29, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cht-sh

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a46spggj532wrhdixjc3bzvcvdsgrm8j-cht.sh-unstable-2018-11-02
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a46spggj532wrhdixjc3bzvcvdsgrm8j-cht.sh-unstable-2018-11-02/bin
patching script interpreter paths in /nix/store/a46spggj532wrhdixjc3bzvcvdsgrm8j-cht.sh-unstable-2018-11-02
/nix/store/a46spggj532wrhdixjc3bzvcvdsgrm8j-cht.sh-unstable-2018-11-02/bin/.cht.sh-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/a46spggj532wrhdixjc3bzvcvdsgrm8j-cht.sh-unstable-2018-11-02...
/nix/store/a46spggj532wrhdixjc3bzvcvdsgrm8j-cht.sh-unstable-2018-11-02

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cht-sh

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i4glfyjcid4xnj37h709lcrkch2xcp7h-cht.sh-unstable-2018-11-02
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i4glfyjcid4xnj37h709lcrkch2xcp7h-cht.sh-unstable-2018-11-02/bin
patching script interpreter paths in /nix/store/i4glfyjcid4xnj37h709lcrkch2xcp7h-cht.sh-unstable-2018-11-02
/nix/store/i4glfyjcid4xnj37h709lcrkch2xcp7h-cht.sh-unstable-2018-11-02/bin/.cht.sh-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/i4glfyjcid4xnj37h709lcrkch2xcp7h-cht.sh-unstable-2018-11-02...
/nix/store/i4glfyjcid4xnj37h709lcrkch2xcp7h-cht.sh-unstable-2018-11-02

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build cht-sh

@worldofpeace worldofpeace changed the title cht.sh: init at unstable-2018-11-02 cht-sh: init at unstable-2018-11-02 Nov 30, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cht-sh

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/kkcm0wm8xqmv9d1yp8am3n4adrv0bhpm-cht.sh-unstable-2018-11-02
strip is /nix/store/bbla06nbjnpi55x9b3zm945vq1mf5fbh-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kkcm0wm8xqmv9d1yp8am3n4adrv0bhpm-cht.sh-unstable-2018-11-02/bin
patching script interpreter paths in /nix/store/kkcm0wm8xqmv9d1yp8am3n4adrv0bhpm-cht.sh-unstable-2018-11-02
/nix/store/kkcm0wm8xqmv9d1yp8am3n4adrv0bhpm-cht.sh-unstable-2018-11-02/bin/.cht.sh-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/bsb6596kk4fp20hyl9yl55xwv1ax4b6s-bash-4.4-p23/bin/sh"
checking for references to /build/ in /nix/store/kkcm0wm8xqmv9d1yp8am3n4adrv0bhpm-cht.sh-unstable-2018-11-02...
/nix/store/kkcm0wm8xqmv9d1yp8am3n4adrv0bhpm-cht.sh-unstable-2018-11-02

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cht-sh

Partial log (click to expand)

no Makefile, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/di34ck27ayi4f5z9yfz8019ykkwfvg4y-cht.sh-unstable-2018-11-02
strip is /nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/di34ck27ayi4f5z9yfz8019ykkwfvg4y-cht.sh-unstable-2018-11-02/bin
patching script interpreter paths in /nix/store/di34ck27ayi4f5z9yfz8019ykkwfvg4y-cht.sh-unstable-2018-11-02
/nix/store/di34ck27ayi4f5z9yfz8019ykkwfvg4y-cht.sh-unstable-2018-11-02/bin/.cht.sh-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/az8gqspcfqr3fdhkscz60qhjnxdh5ggs-bash-4.4-p23/bin/sh"
checking for references to /build/ in /nix/store/di34ck27ayi4f5z9yfz8019ykkwfvg4y-cht.sh-unstable-2018-11-02...
/nix/store/di34ck27ayi4f5z9yfz8019ykkwfvg4y-cht.sh-unstable-2018-11-02

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it appears functional.

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 30, 2018

Weird, the help menu displays

Usage:

    .cht.sh-wrapped --help           show this help
    .cht.sh-wrapped --shell [LANG]   shell mode (open LANG if specified)
    .cht.sh-wrapped QUERY            process QUERY and exit

.cht.sh-wrapped

Tried setting --argv0 with wrapProgram but to no avail.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cht-sh

Partial log (click to expand)

/nix/store/di34ck27ayi4f5z9yfz8019ykkwfvg4y-cht.sh-unstable-2018-11-02

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cht-sh

Partial log (click to expand)

/nix/store/kkcm0wm8xqmv9d1yp8am3n4adrv0bhpm-cht.sh-unstable-2018-11-02

@Ma27
Copy link
Member

Ma27 commented Dec 6, 2018

I couldn't get it working either. And I'm not sure about the semantics of the internally used exec -a: exec -a foo bash works perfectly fine ($0 = foo), but when checking this out with scripts it doesn't work anymore.

Unless there's a simple way I'd suggest fixing the references in the help message via substituteInPlace.

@fgaz
Copy link
Member Author

fgaz commented Dec 7, 2018

@Ma27
Copy link
Member

Ma27 commented Dec 7, 2018

ah I see :)
In this case it would IMHO be best to patch $0 invokations in --help with cht.sh :)

@fgaz
Copy link
Member Author

fgaz commented Jan 11, 2019

@Ma27 Done

@worldofpeace worldofpeace merged commit 70013f2 into NixOS:master Jan 11, 2019
@fgaz fgaz deleted the cht.sh/init branch January 11, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants