Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bisect_ppx and bisect_ppx-ocamlbuild #51276

Merged
merged 3 commits into from Dec 2, 2018

Conversation

Projects
None yet
4 participants
@nomeata
Copy link
Contributor

nomeata commented Nov 30, 2018

No description provided.

@nomeata

This comment has been minimized.

Copy link
Contributor Author

nomeata commented Nov 30, 2018

This is my first PR against nixpkgs, so any comment or advice is appreciated.

@vbgl

This comment has been minimized.

Copy link
Contributor

vbgl commented Nov 30, 2018

Thanks for your contribution. These two files seem to have a lot in common. Can you try to factorize a bit the common parts? For instance, the bisect_ppx-ocamlbuild derivation could inherit a few attributes (src, meta, …) from the bisect_ppx derivation.

@nomeata nomeata force-pushed the nomeata:ocaml-bisect branch to 54ed868 Dec 1, 2018

@nomeata

This comment has been minimized.

Copy link
Contributor Author

nomeata commented Dec 1, 2018

Thanks for your suggestions. Better?

@vbgl
Copy link
Contributor

vbgl left a comment

Would you like to add yourself as a maintainer of these packages?

@nomeata

This comment has been minimized.

Copy link
Contributor Author

nomeata commented Dec 1, 2018

Would you like to add yourself as a maintainer of these packages?

Only if I have to :-)

@vbgl

vbgl approved these changes Dec 2, 2018

@vbgl

This comment has been minimized.

Copy link
Contributor

vbgl commented Dec 2, 2018

@GrahamcOfBorg build ocamlPackages.bisect_ppx ocamlPackages.bisect_ppx-ocamlbuild

@Mic92 Mic92 merged commit 1388223 into NixOS:master Dec 2, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.