Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanagerapplet: fix missing icons #51323

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Gerschtli
Copy link
Contributor

Gerschtli commented Dec 1, 2018

Motivation for this change

Fix missing icons through adding hicolor-icon-theme in buildInputs.

Fixes #32730.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rycee

This comment has been minimized.

Copy link
Member

rycee commented Dec 2, 2018

Thanks! I'd also like to see this merged to 18.09.

@Gerschtli

This comment has been minimized.

Copy link
Contributor Author

Gerschtli commented Dec 2, 2018

Closed as resolved via #51379

@Gerschtli Gerschtli closed this Dec 2, 2018

@Gerschtli Gerschtli deleted the Gerschtli:fix/networkmanagerapplet branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.