Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor HTTPS URLs - the GNU edition #51329

Merged
merged 4 commits into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 1, 2018

Motivation for this change

GNU / Savannah / NonGNU domains always offers HTTPS and often there is even a redirect from plain http to https. So let's save a redirect to users (and Hydra) when following a link to an homepage or to a source tarball. It also updates links in the doc.
More details in the commit messages.

+ a bonus on a small number of SourceForge URLs that were left before

Related: #13809 / #50989
/cc @markuskowa @Infinisil @ryantm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Dec 1, 2018

I guess the mass rebuild is caused by changing the URLs in the some of the patches. If you want to keep that it should maybe go in to staging.

@c0bw3b c0bw3b removed request for matthewbauer , FRidh and Infinisil Dec 1, 2018

@c0bw3b

This comment has been minimized.

Copy link
Contributor Author

c0bw3b commented Dec 1, 2018

No the point is not to trigger a mass-rebuild. I'll undo the changes on patches, it's not necessary and not the important part.

@c0bw3b c0bw3b force-pushed the c0bw3b:cleanup/gnu-https branch to 0498ccd Dec 2, 2018

@c0bw3b

This comment has been minimized.

Copy link
Contributor Author

c0bw3b commented Dec 2, 2018

There! Now we have something practical to work with.
(sorry for the noise)

@markuskowa markuskowa merged commit 506d4c7 into NixOS:master Dec 2, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@c0bw3b c0bw3b deleted the c0bw3b:cleanup/gnu-https branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.