Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdirsyncer: fix build #51349

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
5 participants
@marsam
Copy link
Contributor

marsam commented Dec 1, 2018

Motivation for this change

Disabled vdirsyncer tests, because our version of hypothesis is a bit new pimutils/vdirsyncer#779

Closes #51241

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau

This comment has been minimized.

Copy link
Member

timokau commented Dec 1, 2018

I think it would be better to patch the failure. Otherwise its likely we will forget to re-enable the tests in the future.

@marsam marsam force-pushed the marsam:feature/fix-vdirsyncer branch Dec 1, 2018

@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Dec 1, 2018

sounds reasonable, I've added it as patch

Show resolved Hide resolved pkgs/tools/misc/vdirsyncer/default.nix Outdated
@timokau
Copy link
Member

timokau left a comment

I think the commit message needs updating

vdirsyncer: fix build
- Add support for build on darwin

@marsam marsam force-pushed the marsam:feature/fix-vdirsyncer branch to c154ecf Dec 2, 2018

@marsam

This comment has been minimized.

Copy link
Contributor Author

marsam commented Dec 2, 2018

@timokau thanks, I missed that. updated

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 2, 2018

@GrahamcOfBorg build vdirsyncer

@M-Gregoire

This comment has been minimized.

Copy link
Contributor

M-Gregoire commented Dec 2, 2018

I just tested your branch, It's working perfectly 💯

Thanks for looking into it.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 2, 2018

Tested as well and it builds fine 👍

@worldofpeace worldofpeace merged commit 3f4cbd4 into NixOS:master Dec 2, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@marsam marsam deleted the marsam:feature/fix-vdirsyncer branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.