Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlt: 6.10.0 -> 6.12.0 #51370

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@dtzWill
Copy link
Contributor

dtzWill commented Dec 2, 2018

Motivation for this change

https://github.com/mltframework/mlt/releases/tag/v6.12.0

Notes mention new VA-API support, and other goodies..
among many important fixes! :)

Should look through them more closely,
possibly adding new deps (for vaapi?).

(note to myself but open to anyone with a second :))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.


src = fetchFromGitHub {
owner = "mltframework";
repo = "mlt";
rev = "v${version}";
sha256 = "0ki86yslr5ywa6sz8pjrgd9a4rn2rr4mss2zkmqi7pq8prgsm1fr";
sha256 = "0pzm3mjbbdl2rkbswgyfkx552xlxh2qrwzsi2a4dicfr92rfgq6w";
};

buildInputs = [

This comment has been minimized.

@c0bw3b

c0bw3b Dec 19, 2018

Contributor

At least makeWrapper and pkgconfig should be into nativeBuildInputs

@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Dec 19, 2018

The configure flag --enable-gpl is repeated twice?

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Feb 12, 2019

The configure flag --enable-gpl is repeated twice?

That's how you enable gpl x2 => gplv2 code, right?! 🤣

Cleaning up, thank you for review and apologies for missing these things!
Oh hooray: in my defense the configureArgs were already dup'd haha.
Okay I'll check they don't somehow actually help xD.

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Feb 12, 2019

Seems we half-upgraded this by bumping qt-enabled variant in b0f912b or so. Rebasing/fixing underway...

dtzWill added some commits Feb 12, 2019

mlt: opencv explicitly, add deps SDL2, libexif to enable more
* needs 'which' to find bins from ladspa-sdk, add
* cleanup a bit, qt seems fine as-is (?)

@dtzWill dtzWill force-pushed the dtzWill:update/mlt-6.12.0 branch from ff592c9 to bce556c Feb 12, 2019

@GrahamcOfBorg GrahamcOfBorg requested a review from cillianderoiste Feb 12, 2019

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Feb 12, 2019

Merged the two mlt expressions, which seems high-level good (as well as a few dependencies that seem no heavier than what's already pulled in) but should make sure shotcut and kdenlive both still work. I nuked the "fix motiv.dev" postInstall as likely kruft but will revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.