Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jemalloc: add option disable-initial-exec-tls #51376

Merged
merged 2 commits into from Dec 3, 2018

Conversation

Projects
None yet
4 participants
@Izorkin
Copy link
Contributor

Izorkin commented Dec 2, 2018

Motivation for this change

Add default build option --disable-initial-exec-tls
This option fix error - cannot allocate memory in static TLS block - jemalloc/jemalloc#1237
Need to normal work MariaDB plugin TokuDB

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2018

What is the implication for other applications that work with the current default?

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

Izorkin commented Dec 2, 2018

I do not know. How can the parameter be applied only for mariadb?

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2018

untested:

mariadb.override ({jemalloc = jemalloc.override({disableInitExecTls = true;};}))
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

Izorkin commented Dec 2, 2018

How to add thats variant to pkgs/top-level/all-packages.nix ?

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

Izorkin commented Dec 2, 2018

thats?
mariadb = callPackage ../servers/sql/mariadb {
jemalloc = jemalloc.override({disableInitExecTls = true;});
};

@Izorkin Izorkin force-pushed the Izorkin:jemalloc branch Dec 2, 2018

@Ericson2314
Copy link
Member

Ericson2314 left a comment

This barely needs staging now, which is good! Can always switch the default of disableInitExecTls later.

@Ericson2314 Ericson2314 merged commit 4112aec into NixOS:staging Dec 3, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@Izorkin Izorkin deleted the Izorkin:jemalloc branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.