Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nm-applet: add nm-applet program #51379

Merged
merged 3 commits into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@Gerschtli
Copy link
Contributor

Gerschtli commented Dec 2, 2018

Motivation for this change

Add systemd user service to start nm-applet on graphical-session.target.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gerschtli Gerschtli requested a review from Infinisil as a code owner Dec 2, 2018


programs.nm-applet = {

enable = mkOption {

This comment has been minimized.

@Mic92

Mic92 Dec 2, 2018

Contributor

nitpick:

enable = mkEnableOption "nm-applet":

Mic92 added some commits Dec 2, 2018

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2018

I also noticed that icons where missing when started as service.

@Mic92 Mic92 merged commit 31f67be into NixOS:master Dec 2, 2018

1 check was pending

grahamcofborg-eval Checking original out paths
Details
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2018

I backported the icon theme fix: 49be1fa

@Gerschtli

This comment has been minimized.

Copy link
Contributor Author

Gerschtli commented Dec 2, 2018

Thank you!

@Gerschtli Gerschtli deleted the Gerschtli:add/programs-nm-applet branch Dec 2, 2018

@Gerschtli Gerschtli referenced this pull request Dec 2, 2018

Closed

networkmanagerapplet: fix missing icons #51323

3 of 10 tasks complete

@Mic92 Mic92 referenced this pull request Dec 4, 2018

Open

kdeconnect: init module #51474

2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.