Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network-manager: rename systemd service back to match upstream #51383

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@M-Gregoire
Copy link
Contributor

M-Gregoire commented Dec 2, 2018

Motivation for this change

Following the discussion in #51375, rename the network-manager service to NetworkManager to match upstream.

Things done

Backport #51382

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@M-Gregoire M-Gregoire requested a review from Infinisil as a code owner Dec 2, 2018

@M-Gregoire M-Gregoire force-pushed the M-Gregoire:fix/networkmanager branch 2 times, most recently Dec 2, 2018

@M-Gregoire

This comment has been minimized.

Copy link
Contributor Author

M-Gregoire commented Dec 2, 2018

Just rebuilt and tested NetworkManager-wait-online.service. All working fine 👍
@Mic92

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2018

I think there was a misunderstanding. What I meant to say is that we patch the NetworkManager-wait-online.service for 18.09 to point to network-manager.service and undo the renaming for master so that this renaming is not necessary.
The code for 18.09 is on the release-18.09 branch.
My pull request will fix master so that only the 18.09 stuff needs to be done.

@M-Gregoire

This comment has been minimized.

Copy link
Contributor Author

M-Gregoire commented Dec 2, 2018

Indeed, my bad sorry!
Closing this issue

@M-Gregoire M-Gregoire closed this Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.