Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitea: 1.5.3 -> 1.6.0 #51386

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
4 participants
@cryptix
Copy link
Contributor

cryptix commented Dec 2, 2018

Motivation for this change

Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.6.0

from the security section:

  • Add CSRF checking to reqToken and add reqToken to admin API routes
  • Improve URL validation for external wiki and external issues
  • Make cookies HttpOnly and obey COOKIE_SECURE flag
  • Don't disclose emails of all users when sending out emails
  • Check that repositories can only be migrated to own user or organizations
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Dec 5, 2018

@GrahamcOfBorg build gitea

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Dec 5, 2018

Let's see aarch64 does not run into trouble with thread limits on the second try:
@GrahamcOfBorg build gitea

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Dec 5, 2018

@GrahamcOfBorg test gitea

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Dec 5, 2018

@GrahamcOfBorg build nixosTests.gitea

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Dec 5, 2018

aarch64 fails with

runtime: failed to create new OS thread (have 6 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc

Same problem with the last PR: #50229
However, Hydra could build it: https://hydra.nixos.org/build/85306028

@markuskowa markuskowa merged commit 0236b34 into NixOS:master Dec 5, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@cryptix cryptix deleted the cryptix:update/gitea branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.