Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunar-archive-plugin: 0.3.1 -> 0.4 #51387

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@M-Gregoire
Copy link
Contributor

M-Gregoire commented Dec 2, 2018

Things done

Updates thunar-archive-plugin to latest release.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 2, 2018

@GrahamcOfBorg build thunar-archive-plugin

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 3, 2018

@GrahamcOfBorg build xfce4-12.thunar-archive-plugin

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 3, 2018

Build failed with:

checking for thunarx-3 >= 0.4.0... not found
*** The required package thunarx-3 was not found on your system.
*** Please install thunarx-3 (atleast version 0.4.0) or adjust
*** the PKG_CONFIG_PATH environment variable if you
*** installed the package in a nonstandard prefix so that
*** pkg-config is able to find it.
@M-Gregoire

This comment has been minimized.

Copy link
Contributor Author

M-Gregoire commented Dec 3, 2018

Thank you @worldofpeace !
I'm not sure on how I can fix this problem though. As far as I understand, thunarx is an interface for thunar but I'm not sure how I should be installed.

I've made a PR to update (#51438) Thunar but I'm unsure this will fix the problem.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 3, 2018

@volth I don't think we should be doing this?

@volth

This comment has been minimized.

Copy link
Contributor

volth commented Dec 3, 2018

@volth I don't think we should be doing this?

I am not sure.
As it is GTK3 port (https://github.com/xfce-mirror/thunar-archive-plugin/blob/master/NEWS#L1-L3) it might have to belong to xfce4-13.

But if it works with xfce4-12 and people needs it, ...

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 3, 2018

As it is GTK3 port (https://github.com/xfce-mirror/thunar-archive-plugin/blob/master/NEWS#L1-L3) it might have to belong to xfce4-13.

Yeah that sounds right. All the versions required are at the gtk3 port.

@Ekleog

This comment has been minimized.

Copy link
Member

Ekleog commented Dec 8, 2018

@volth Can you write again the information in the message you apparently deleted? Deletion makes reading the PR comments totally useless, especially as this deleted comment appears to contain what both you and @worldofpeace agreed on… but I can't be sure, and neither can, I think, anyone who wasn't there at the time you made that now-deleted comment.

@volth

This comment has been minimized.

Copy link
Contributor

volth commented Dec 8, 2018

@Ekleog here are no deleteded messages (anyway Github shows them folded nowadays), @worldofpeace started the conversation with @volth I don't think we should be doing this?, probably after having found me in git blame

@Ekleog

This comment has been minimized.

Copy link
Member

Ekleog commented Dec 8, 2018

@volth Oh, sorry for having thought you deleted one of your messages, then :)

Now… Well, I came here through triage, and must say I don't understand the comments enough to get what is the current state of this PR is (is it wanted? what is the remaining work required?), so if you or @worldofpeace can comment on this it'd be great :)

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 8, 2018

Well, I came here through triage, and must say I don't understand the comments enough to get what is the current state of this PR is (is it wanted? what is the remaining work required?), so if you or @worldofpeace can comment on this it'd be great :)

If the author wants this version of thunar-archive-plugin, they must add it
under the attribute set xfce-4-13.
This particular version of thunar-archive-plugin should not be upgraded.
Same with #51438.

@M-Gregoire

This comment has been minimized.

Copy link
Contributor Author

M-Gregoire commented Dec 10, 2018

Thank you for you explanation. Closing this issue, will reopen one for xfce-4-13 if needed.

@M-Gregoire M-Gregoire closed this Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.