Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jq: fix download hash #51405

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
4 participants
@dylex
Copy link
Contributor

dylex commented Dec 2, 2018

Motivation for this change

It looks like the upstream download file for jq 1.6 has changed (this seems to be an attached source tarball on github, not an actual hash download).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rasendubi

This comment has been minimized.

Copy link
Member

rasendubi commented Dec 2, 2018

I confirm the hash is different for me, too

rasen@omicron ~/p/nixpkgs> nix-build -A jq.src --check
checking outputs of '/nix/store/mm0vjqh9pswlqahbryq24h3rr9k8qp1v-jq-1.6.tar.gz.drv'...

trying https://github.com/stedolan/jq/releases/download/jq-1.6/jq-1.6.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   602    0   602    0     0    671      0 --:--:-- --:--:-- --:--:--   670
100 1709k  100 1709k    0     0   445k      0  0:00:03  0:00:03 --:--:--  625k
warning: rewriting hashes in '/nix/store/wxib70mfqfw6i67cplpdwj79f1gs9qr9-jq-1.6.tar.gz'; cross fingers
fixed-output derivation produced path '/nix/store/ggjlgjx2fw29lngbnvwaqr6hiz1qhy8g-jq-1.6.tar.gz' with sha256 hash '0wmapfskhzfwranf6515nzmm84r7kwljgfs7dg6bjgxakbicis2x' instead of the expected hash '1a76f46a652i2g333kfvrl6mp2w7whf6h1yly519izg4y967h9cn'
error: build of '/nix/store/mm0vjqh9pswlqahbryq24h3rr9k8qp1v-jq-1.6.tar.gz.drv' failed

@GrahamcOfBorg build jq

@arianvp

This comment has been minimized.

Copy link
Contributor

arianvp commented Dec 2, 2018

Can we first check why it changed before merging this?

@rasendubi

This comment has been minimized.

Copy link
Member

rasendubi commented Dec 2, 2018

@rasendubi rasendubi merged commit 92a8711 into NixOS:master Dec 2, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.