Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cockroachdb: supply defaultText for the package option #51409

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
4 participants
@pbogdan
Copy link
Contributor

pbogdan commented Dec 2, 2018

Motivation for this change

This was preventing evaluating the NixOS manual on platforms not supported by cockroachdb package itself:

Package ‘cockroach-2.1.1’ in /home/pbogdan/nixpkgs/pkgs/servers/sql/cockroachdb/default.nix:59 is not supported on ‘i686-unknown-linux-gnu’, refusing to evaluate.

Notably this currently prevents the tested Hydra job from evaluating as the manual is one of the constituents.

https://hydra.nixos.org/jobset/nixos/trunk-combined#tabs-errors -> CTRL-F "in job ‘tested’:"

/cc @thoughtpolice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pbogdan pbogdan requested a review from Infinisil as a code owner Dec 2, 2018

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Dec 2, 2018

@thoughtpolice thoughtpolice merged commit 9ca3414 into NixOS:master Dec 3, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@thoughtpolice

This comment has been minimized.

Copy link
Member

thoughtpolice commented Dec 3, 2018

Thanks for the catch. Sorry about that @pbogdan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.