Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tradcpp: improved aarch64 support #51585

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

@veprbl
Copy link
Member

veprbl commented Dec 5, 2018

Motivation for this change

Fixes #51578

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-review pr 51585
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl mentioned this pull request Dec 5, 2018
3 of 10 tasks complete
@veprbl

This comment has been minimized.

Copy link
Member Author

veprbl commented Dec 5, 2018

@GrahamcOfBorg build tradcpp x11_ssh_askpass

@veprbl

This comment has been minimized.

Copy link
Member Author

veprbl commented Dec 5, 2018

I've just reported the bug and my patch to NetBSD.

#elif defined(__ARM__)
#define CONFIG_CPU "__ARM__"
+#elif defined(__aarch64__)
+#define CONFIG_CPU "__aarch64__"

This comment has been minimized.

Copy link
@Mic92

Mic92 Dec 6, 2018

Contributor

I am sure netbsd would also accept this as a patch upstream.

This comment has been minimized.

Copy link
@veprbl

veprbl Dec 6, 2018

Author Member

@Mic92 Why do you think so?

This comment has been minimized.

Copy link
@veprbl

veprbl Dec 6, 2018

Author Member

@Mic92 Sorry, I think I misread your comment. I agree, the patch is reasonable, so they probably will accept it.

This comment has been minimized.

Copy link
@Mic92

Mic92 Dec 7, 2018

Contributor

I have sent it to dholland, the maintainer.

This comment has been minimized.

Copy link
@Mic92

Mic92 Jan 22, 2019

Contributor

I got a response:

On Fri, Dec 07, 2018 at 10:51:46AM +0000, J?rg Thalheim wrote:
 > This has been added in https://github.com/NixOS/nixpkgs/pull/51585

Several people sent this in more or less at once... anyway I just
posted a new tarball (0.5.3) with this and a few other similar bits.

Thanks.

This comment has been minimized.

Copy link
@veprbl

veprbl Jan 22, 2019

Author Member

@Mic92 The other person must be me.

@Mic92 Mic92 merged commit dca1fe7 into NixOS:master Dec 7, 2018
15 checks passed
15 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A tradcpp --argstr system aarch64-linux Build Results
Details
nix-build -A tradcpp --argstr system x86_64-darwin Build Results
Details
nix-build -A tradcpp --argstr system x86_64-linux Build Results
Details
nix-build -A tradcpp -A x11_ssh_askpass --argstr system aarch64-linux Build Results
Details
nix-build -A tradcpp -A x11_ssh_askpass --argstr system x86_64-darwin Build Results
Details
nix-build -A tradcpp -A x11_ssh_askpass --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.