Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yed: 3.18.1.1 -> 3.18.2 #51592

Merged
merged 1 commit into from Dec 7, 2018
Merged

yed: 3.18.1.1 -> 3.18.2 #51592

merged 1 commit into from Dec 7, 2018

Conversation

@yegortimoshenko
Copy link
Member

yegortimoshenko commented Dec 5, 2018

Motivation for this change

Bump yEd, current derivation won't fetch anymore, they removed the src archive.

Change requireFile to fetchzip because that's what Arch Linux does and EULA doesn't seem to prohibit automated downloads.

cc @orivej

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Dec 6, 2018

Isn't the fact that the download is normally locked behind a EULA sufficient to argue that requireFile is the right way?

@rasendubi

This comment has been minimized.

Copy link
Member

rasendubi commented Dec 6, 2018

There was a similar precedent for VirtualBox extension pack #44896. Download requires accepting VirtualBox Personal Use and Evaluation License (PUEL), so the PR added virtualbox-puel license to nixpkgs.

@Mic92 Mic92 merged commit fc7eef5 into master Dec 7, 2018
12 checks passed
12 checks passed
nix-build -A yed --argstr system aarch64-linux Build Results
Details
nix-build -A yed --argstr system x86_64-darwin Build Results
Details
nix-build -A yed --argstr system x86_64-linux Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@yegortimoshenko yegortimoshenko deleted the yegortimoshenko-patch-1 branch Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.