Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint: 2.1.1 -> 2.2.2 #51634

Merged
merged 2 commits into from Dec 7, 2018
Merged

pylint: 2.1.1 -> 2.2.2 #51634

merged 2 commits into from Dec 7, 2018

Conversation

@jokogr
Copy link
Contributor

jokogr commented Dec 6, 2018

Motivation for this change

pylint was failing some tests in master and thought to update it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jokogr jokogr requested a review from FRidh as a code owner Dec 6, 2018
@flokli flokli merged commit b89978c into NixOS:master Dec 7, 2018
9 checks passed
9 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 7, 2018

from nox-review, /nix/store/pxvwqagvn5vk3bpjgfgwygqmgqqsdr4m-python3.7-pyside-shiboken-1.2.4.drv (for that reason, spyder) seems to be broken too.

@jokogr

This comment has been minimized.

Copy link
Contributor Author

jokogr commented Dec 7, 2018

@flokli I am sorry, I did not run nox-review. Unless anyone else makes a PR, I promise to deal with that later today.

@jokogr jokogr deleted the jokogr:u/pylint-2.2.2 branch Dec 7, 2018
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 7, 2018

@jokogr no worries, it was already broken before - thanks a lot for fixing it!

@jokogr jokogr mentioned this pull request Dec 8, 2018
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.