Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tectonic: 0.1.9 -> 0.1.11 #51640

Merged
merged 1 commit into from Dec 7, 2018
Merged

tectonic: 0.1.9 -> 0.1.11 #51640

merged 1 commit into from Dec 7, 2018

Conversation

@das-g
Copy link
Contributor

das-g commented Dec 6, 2018

Motivation for this change
  • handles unicode filenames correctly (since 0.1.10)
  • switch to hopefully more reliable permantent URL for the default bundle (in 0.1.11)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @lluchs

- handles unicode filenames correctly (since 0.1.10)
- switch to hopefully more reliable permantent URL for the default bundle (in 0.1.11)
@nlewo

This comment has been minimized.

Copy link
Member

nlewo commented Dec 7, 2018

@GrahamcOfBorg build tectonic

@srhb srhb merged commit 0ba6752 into NixOS:master Dec 7, 2018
12 checks passed
12 checks passed
nix-build -A tectonic --argstr system x86_64-darwin Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A tectonic --argstr system aarch64-linux Build Results
Details
nix-build -A tectonic --argstr system x86_64-linux Build Results
Details
@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Dec 7, 2018

I notice this hasn't been updated since 0.1.8 on 18.09. Shall I backport both?

@das-g das-g deleted the das-g:tectonic-0.1.11 branch Dec 7, 2018
@das-g

This comment has been minimized.

Copy link
Contributor Author

das-g commented Dec 7, 2018

I notice this hasn't been updated since 0.1.8 on 18.09.

Yeah, a backport would be appreciated. I can make a PR for one, if wanted.

Shall I backport both?

What do you mean by "both"? 0.1.9 as well as 0.1.11? I doubt that's needed, let's just backport the latest version. Or did you mean something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.