Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vivaldi: correct hash #51646

Merged
merged 1 commit into from Dec 7, 2018
Merged

vivaldi: correct hash #51646

merged 1 commit into from Dec 7, 2018

Conversation

@worldofpeace
Copy link
Member

worldofpeace commented Dec 7, 2018

Motivation for this change

Fixes #51635

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes #51635
@flokli flokli merged commit 57c69ff into NixOS:master Dec 7, 2018
11 checks passed
11 checks passed
nix-build -A vivaldi --argstr system aarch64-linux Build Results
Details
nix-build -A vivaldi --argstr system x86_64-linux Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 7, 2018

@worldofpeace thanks! just to make sure, the current version and hash on 18.09 is fine and not broken?

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Dec 7, 2018

@worldofpeace thanks! just to make sure, the current version and hash on 18.09 is fine and not broken?

Should be fine since Vivaldi in 18.09 is at 1.15.1147.42-1 and master is at 2.1.1337.51-1.
Though I think we should be backporting any browser updates for security.

@worldofpeace worldofpeace deleted the worldofpeace:vivaldi/correct-hash branch Dec 7, 2018
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 7, 2018

Does Vivaldi provide some sort of changelog, so we know there's no current open security our current 1.15.x version?

Do they even consider 1.15.x a "stable branch", that's receiving any updates?

If they don't, we should bump 18.09 too 2.1.x, too…

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Dec 7, 2018

It's chromium based so all chromium security issues effect Vivaldi. So backporting is needed.

Do they even consider 1.15.x a "stable branch", that's receiving any updates?

If you look at the url, on master, we're at the stable release.

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 7, 2018

It's chromium based so all chromium security issues effect Vivaldi. So backporting is needed.

Yes, but there's no listing of versions released, to see which version adresses a CVE / bumps chromium etc.

Do they even consider 1.15.x a "stable branch", that's receiving any updates?

If you look at the url, on master, we're at the stable release.

The 1.15.x version from 18.09 uses the same URL pattern, so there was a major version bump on their stable branch, and we should bump to that version on 18.09 as well.

@worldofpeace Can you prepare a PR for that?

@worldofpeace

This comment has been minimized.

Copy link
Member Author

worldofpeace commented Dec 7, 2018

Yes, but there's no listing of versions released, to see which version adresses a CVE / bumps chromium etc.

Just to know for the future, the changelog can be seen at https://update.vivaldi.com/update/X.x/relnotes/Major.minor.build.html

Here's the most recent one https://update.vivaldi.com/update/1.0/relnotes/2.1.1337.51.html

The 1.15.x version from 18.09 uses the same URL pattern, so there was a major version bump on their stable branch, and we should bump to that version on 18.09 as well.
@worldofpeace Can you prepare a PR for that?

Of course 👍

@worldofpeace worldofpeace mentioned this pull request Dec 8, 2018
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.