Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systrayhelper: 0.0.4 -> 0.0.5 #51652

Closed
wants to merge 1 commit into from
Closed

Conversation

@cryptix
Copy link
Contributor

cryptix commented Dec 7, 2018

Motivation for this change

updates to the latest release v0.0.5 which includes some fixes and dependency updates.

also includes a checkPhase using xvfb_run to spawn go test, which starts i3 and the helper and then uses xdotool to send clicks back to the helper

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

nixos-discourse commented Dec 7, 2018

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/using-xvfb-in-checkphase/1497/4

@rasendubi
Copy link
Member

rasendubi commented Dec 7, 2018

Is this a WIP? Otherwise, you need remove commented out code / todos (don't forget ...)

@cryptix
Copy link
Contributor Author

cryptix commented Dec 13, 2018

@rasendubi: indeed an oversight, thanks!

I'll try to add the ffmpeg record mechanics in pre/postCheckHook so that I can use them through an override from the source.

@Mic92 Mic92 changed the title systrayhelper: 0.0.4 -> 0.0.5 [WIP] systrayhelper: 0.0.4 -> 0.0.5 Dec 13, 2018
@rasendubi
Copy link
Member

rasendubi commented Jan 4, 2019

(triage) @cryptix any updates? do you need any help?

@cryptix cryptix force-pushed the cryptix:update/systrayhelper branch from f5a72f1 to b831bec Jan 22, 2019
@cryptix
Copy link
Contributor Author

cryptix commented Jan 22, 2019

@rasendubi sorry, yes/no. this mostly got dragged behind. I pushed a rebased and cleaned up version.

I moved the commented stuff to export test video recordings into the override.nix in the source of the project to unclutter this one.

Also removed the deps.nix file since this uses vendored dependencies.

Copy link
Member

rasendubi left a comment

Minor comments. Otherwise, it looks good.

When you think PR is ready for the final review and merge, remove [WIP] from the title.

pkgs/tools/misc/systrayhelper/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/systrayhelper/default.nix Outdated Show resolved Hide resolved
@cryptix cryptix force-pushed the cryptix:update/systrayhelper branch from b831bec to a28276b May 11, 2019
@cryptix cryptix changed the title [WIP] systrayhelper: 0.0.4 -> 0.0.5 systrayhelper: 0.0.4 -> 0.0.5 May 11, 2019
@cryptix
Copy link
Contributor Author

cryptix commented May 11, 2019

updated to respect review comments and rebased on master.

@rasendubi
Copy link
Member

rasendubi commented May 11, 2019

@GrahamcOfBorg build systrayhelper

@rasendubi
Copy link
Member

rasendubi commented May 11, 2019

nix-review fails for me with the following error:

builder for '/nix/store/pbyhaj1ls312xlmvxgxljls5n7m2bwcv-systrayhelper-0.0.5.drv' failed with exit code 1; last 10 log lines:
      xvfb_test.go:32: found i3-msg here: /nix/store/nnskv7cmcv35nvhsac5pcjfddqd6i2lr-i3-4.16.1/bin/i3-msg
      xvfb_test.go:32: found xdotool here: /nix/store/ivkzr71ck6in70p5k8gr0mqm8zbxdi81-xdotool-3.20160805.1/bin/xdotool
      require.go:794: 
          	Error Trace:	xvfb_test.go:31
          	Error:      	Received unexpected error:
          	            	exec: "systrayhelper": executable file not found in $PATH
          	Test:       	TestClicking
          	Messages:   	did not find systrayhelper
  FAIL
  FAIL	github.com/ssbc/systrayhelper/test	0.003s
cannot build derivation '/nix/store/f3fyzpn9y8j0h1kblx5mrhsfhvfb2749-env.drv': 1 dependencies couldn't be built

I think export PATH=$PATH:$(pwd)/go/bin is still needed in checkPhase (without i3 and xdotool)

@doronbehar
Copy link
Contributor

doronbehar commented May 16, 2020

I'm closing as CI fails and OP seems to not care as for making this update work and to much time has passed.

@doronbehar doronbehar closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.