Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cytoolz: fix build #51663

Merged
merged 1 commit into from Dec 12, 2018
Merged

Conversation

@erictapen
Copy link
Contributor

erictapen commented Dec 7, 2018

cytoolz has a test failure with Python 3.7. There is a debian patch for it, which didn't make it into upstream yet.

Motivation for this change

python3Packages.cytoolz does not build on master.

Things done

Apply the patch from debian.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Dec 7, 2018

This will conflict with b5cb0f0, even though your fix looks better.

@erictapen

This comment has been minimized.

Copy link
Contributor Author

erictapen commented Dec 7, 2018

@dotlambda Hoopsie, didn't see that commit! Also maybe I should have directed this PR to staging, didn't check how many packages would be affected. Would you find 10-100 rebuilds to be reasonable for master?

@erictapen

This comment has been minimized.

Copy link
Contributor Author

erictapen commented Dec 8, 2018

@GrahamcOfBorg build python3Packages.cytoolz

pkgs/development/python-modules/cytoolz/default.nix Outdated
# temporal fix for a test failure: https://github.com/pytoolz/cytoolz/issues/122
(fetchpatch {
name = "py37.patch";
url = "https://salsa.debian.org/python-team/modules/python-cytoolz/raw/master/debian/patches/py37.patch";

This comment has been minimized.

Copy link
@Mic92

Mic92 Dec 8, 2018

Contributor
Suggested change
url = "https://salsa.debian.org/python-team/modules/python-cytoolz/raw/master/debian/patches/py37.patch";
url = "https://salsa.debian.org/python-team/modules/python-cytoolz/raw/5ce4158deefc47475d1e76813f900e6c72ddcc6e/debian/patches/py37.patch";

This comment has been minimized.

Copy link
@erictapen

erictapen Dec 8, 2018

Author Contributor

Oh of course! Fixed it.

This comment has been minimized.

Copy link
@dotlambda

dotlambda Dec 11, 2018

Member

You should also change the URL in the commit messsage.
And a minor nitpick: some people prefer using quotes-free URLs given this is a thing in Nix.

This comment has been minimized.

Copy link
@erictapen

erictapen Dec 11, 2018

Author Contributor

+1 fixed it

@erictapen erictapen force-pushed the erictapen:cytoolz-fix-build branch 2 times, most recently Dec 8, 2018
@erictapen

This comment has been minimized.

Copy link
Contributor Author

erictapen commented Dec 10, 2018

rebased to current master.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 10, 2018

@GrahamcOfBorg build python3Packages.cytoolz python2Packages.cytoolz

@erictapen erictapen force-pushed the erictapen:cytoolz-fix-build branch 2 times, most recently Dec 11, 2018
cytoolz has a test failure with Python 3.7 [0]. There is a debian patch
for it, which didn't make it into upstream yet [1].

[0] pytoolz/cytoolz#122
[1] https://salsa.debian.org/python-team/modules/python-cytoolz/raw/5ce4158deefc47475d1e76813f900e6c72ddcc6e/debian/patches/py37.patch
@erictapen erictapen force-pushed the erictapen:cytoolz-fix-build branch to df6010a Dec 11, 2018
@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Dec 12, 2018

@GrahamcOfBorg build python3Packages.cytoolz python2Packages.cytoolz

@worldofpeace worldofpeace merged commit d36846d into NixOS:master Dec 12, 2018
12 checks passed
12 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A python2Packages.cytoolz -A python3Packages.cytoolz --argstr system aarch64-linux Build Results
Details
nix-build -A python2Packages.cytoolz -A python3Packages.cytoolz --argstr system x86_64-darwin Build Results
Details
nix-build -A python2Packages.cytoolz -A python3Packages.cytoolz --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.