Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opusTools: 0.1.10 -> 0.2 #51665

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

@pmiddend
Copy link
Contributor

pmiddend commented Dec 7, 2018

Motivation for this change

Now that libopusenc is in nixpkgs, we can upgrade opus-tools, too!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Dec 7, 2018

@GrahamcOfBorg build opus-tools

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Dec 7, 2018

@GrahamcOfBorg build opusTools

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Dec 7, 2018

@pmiddend would you mind updating your commit message to use the correct attribute name?

@pmiddend pmiddend force-pushed the plapadoo:opus-tools-0.1.10-to-0.2 branch to a17d94a Dec 7, 2018
@pmiddend

This comment has been minimized.

Copy link
Contributor Author

pmiddend commented Dec 7, 2018

@alyssais Good catch! Fixed that.

@pmiddend pmiddend changed the title opus-tools: 0.1.10 -> 0.2 opusTools: 0.1.10 -> 0.2 Dec 7, 2018
@alyssais alyssais merged commit 21ed8b1 into NixOS:master Dec 7, 2018
9 checks passed
9 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@pmiddend pmiddend deleted the plapadoo:opus-tools-0.1.10-to-0.2 branch Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.