Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.flit: 1.0 -> 1.2.1 #51674

Merged
merged 1 commit into from Dec 23, 2018
Merged

Conversation

@costrouc
Copy link
Contributor

costrouc commented Dec 7, 2018

Motivation for this change

flit adds requires-extra to newer versions for extra packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner Dec 7, 2018
@costrouc

This comment has been minimized.

Copy link
Contributor Author

costrouc commented Dec 7, 2018

@GrahamcOfBorg build python3Packages.flit

@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Dec 8, 2018

I have the following error on darwin https://gist.github.com/f81d5d423166629af2ac31dbe8e4b555, because the tests fail with /homeless-shelter; would you mind adding the following?

diff --git c/pkgs/development/python-modules/flit/default.nix i/pkgs/development/python-modules/flit/default.nix
index ecda1b5efad..7c64d9bd183 100644
--- c/pkgs/development/python-modules/flit/default.nix
+++ i/pkgs/development/python-modules/flit/default.nix
@@ -36,7 +36,7 @@ buildPythonPackage rec {
   # Disable test that needs some ini file.
   # Disable test that wants hg
   checkPhase = ''
-    py.test -k "not test_invalid_classifier and not test_build_sdist"
+    HOME=$(mktemp -d) pytest -k "not test_invalid_classifier and not test_build_sdist"
   '';
 
   meta = {
@costrouc

This comment has been minimized.

Copy link
Contributor Author

costrouc commented Dec 8, 2018

I was dumb to not nix-review and see the impace of these changes since this is such a significant package. Thanks @marsam and I will need more input to make sure this doesn't break more Darwin packages

@costrouc costrouc force-pushed the costrouc:python-upgdate-flit branch to 2294ae7 Dec 8, 2018
@costrouc

This comment has been minimized.

Copy link
Contributor Author

costrouc commented Dec 8, 2018

Fixed.

@marsam
marsam approved these changes Dec 8, 2018
@dotlambda dotlambda merged commit 142687c into NixOS:master Dec 23, 2018
9 checks passed
9 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.