Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pro-office-calculator: init at 1.0.6 #51677

Merged
merged 1 commit into from Dec 13, 2018
Merged

Conversation

@pmiddend
Copy link
Contributor

pmiddend commented Dec 7, 2018

Motivation for this change

Seems to be an addicting game, and it's not in nixpkgs yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien

This comment has been minimized.

Copy link
Contributor

symphorien commented Dec 8, 2018

When running it (on x86_64-linux) I get an illegal instruction:

Program received signal SIGILL, Illegal instruction.
0x00007ffff5b2f1c5 in ?? () from /nix/store/x3jacyl2lp46wcd6n9qyn07rhafnsp1q-gcc-7.3.0-lib/lib/libstdc++.so.6
(gdb) where
#0  0x00007ffff5b2f1c5 in ?? () from /nix/store/x3jacyl2lp46wcd6n9qyn07rhafnsp1q-gcc-7.3.0-lib/lib/libstdc++.so.6
#1  0x00007ffff5b2f332 in std::random_device::_M_getval() () from /nix/store/x3jacyl2lp46wcd6n9qyn07rhafnsp1q-gcc-7.3.0-lib/lib/libstdc++.so.6
#2  0x0000000000514c10 in randomSeed() ()
#3  0x00000000004219d6 in _GLOBAL__sub_I_game_logic.cpp ()
#4  0x00000000005427ad in __libc_csu_init ()
#5  0x00007ffff4f11b1d in __libc_start_main () from /nix/store/mrfcv8ipiksfdrx3xq7dvcrzgg2jdfsw-glibc-2.27/lib/libc.so.6
#6  0x0000000000423eaa in _start ()
@pmiddend

This comment has been minimized.

Copy link
Contributor Author

pmiddend commented Dec 8, 2018

@symphorien "Works for me", same architecture. What could be the difference between our machines?

@pmiddend

This comment has been minimized.

Copy link
Contributor Author

pmiddend commented Dec 9, 2018

Can anybody else test this on their machine?

@symphorien

This comment has been minimized.

Copy link
Contributor

symphorien commented Dec 9, 2018

The illegal instruction is rdrand, and indeed my processor does not support it.
Given the backtrace, it seems this is not a bug in pro-office-calculator, but deeper in the dependency tree. Maybe the libstdc++ is built with rdrand support mandatory (this would surprise me, but...)
In any case it is probably not a blocker for your PR.

@symphorien

This comment has been minimized.

Copy link
Contributor

symphorien commented Dec 9, 2018

In fact I think it is a bug in pro-office-calculator: RobJinman/pro_office_calc#5

@pmiddend

This comment has been minimized.

Copy link
Contributor Author

pmiddend commented Dec 10, 2018

I'll try to incorporate the patch into the derivation.

@pmiddend pmiddend force-pushed the plapadoo:pro-office-calculator-init branch from 5de0c08 to cd075e5 Dec 10, 2018
@pmiddend

This comment has been minimized.

Copy link
Contributor Author

pmiddend commented Dec 10, 2018

@symphorien Ok, done. Can you test again?

@symphorien

This comment has been minimized.

Copy link
Contributor

symphorien commented Dec 11, 2018

It works, thanks.

@srhb srhb merged commit b64e71e into NixOS:master Dec 13, 2018
11 checks passed
11 checks passed
nix-build -A pro-office-calculator --argstr system aarch64-linux Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A pro-office-calculator --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.