Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bash: set title in PS1 #51678

Merged
merged 1 commit into from Dec 8, 2018
Merged

nixos/bash: set title in PS1 #51678

merged 1 commit into from Dec 8, 2018

Conversation

@yegortimoshenko
Copy link
Member

yegortimoshenko commented Dec 7, 2018

Motivation for this change

Before:

before

After:

after

This is the default behavior on Debian. It helps to differentiate between different NixOS systems (when some windows run SSH) and between different local paths, while also properly integrating with Vim's set title.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Dec 7, 2018

LGTM!

@Ma27
Ma27 approved these changes Dec 8, 2018
@yegortimoshenko yegortimoshenko merged commit 5c685fe into master Dec 8, 2018
9 checks passed
9 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@yegortimoshenko yegortimoshenko deleted the yegortimoshenko-patch-1 branch Dec 8, 2018
hedning added a commit to hedning/nixpkgs that referenced this pull request Dec 9, 2018
Probably due to NixOS#51678 which makes bash set the terminal title.
@tadfisher

This comment has been minimized.

Copy link
Contributor

tadfisher commented Dec 17, 2018

This broke my Emacs prompt, btw.

@tadfisher

This comment has been minimized.

Copy link
Contributor

tadfisher commented Dec 17, 2018

Example:

[0;tad@curie: ~/src/pass-otptad@curie:~/src/pass-otp]$ 
@tadfisher tadfisher mentioned this pull request Dec 17, 2018
3 of 10 tasks complete
@@ -98,7 +98,7 @@ in
if [ "$TERM" != "dumb" -o -n "$INSIDE_EMACS" ]; then
PROMPT_COLOR="1;31m"
let $UID && PROMPT_COLOR="1;32m"
PS1="\n\[\033[$PROMPT_COLOR\][\u@\h:\w]\\$\[\033[0m\] "

This comment has been minimized.

Copy link
@Mic92

Mic92 Dec 18, 2018

Contributor

Before there were two \\ before the dollar sign. Was this indented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.