Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intelmetool: init at 4.8.1 #51679

Merged
merged 1 commit into from Dec 13, 2018
Merged

intelmetool: init at 4.8.1 #51679

merged 1 commit into from Dec 13, 2018

Conversation

@gnidorah
Copy link
Member

gnidorah commented Dec 7, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

srhb left a comment

I am wondering whether it would make sense to reuse the src and version from nvramtool, but I guess there's not much precedent for that. The duplication just seems a little off to me, but probably no biggie.

pkgs/tools/misc/intelmetool/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/intelmetool/default.nix Outdated Show resolved Hide resolved
@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Dec 12, 2018

@GrahamcOfBorg build intelmetool

@gnidorah gnidorah force-pushed the gnidorah:intelmetool branch to bc4c3e5 Dec 13, 2018
@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Dec 13, 2018

@srhb Also cbfstool uses the same repo. Should be tested after version bump though. What would be correct way to share src and version between them? Is there any example in nixpkgs?

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Dec 13, 2018

@gnidorah I haven't found any, so at least it's not prevalent :/

@srhb

This comment has been minimized.

Copy link
Contributor

srhb commented Dec 13, 2018

@GrahamcOfBorg build intelmetool

@srhb
srhb approved these changes Dec 13, 2018
@srhb srhb merged commit d770355 into NixOS:master Dec 13, 2018
11 checks passed
11 checks passed
nix-build -A intelmetool --argstr system x86_64-darwin Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A intelmetool --argstr system x86_64-linux Build Results
Details
@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Dec 13, 2018

@srhb Thanks!

@gnidorah gnidorah deleted the gnidorah:intelmetool branch Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.