Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni/cni-plugins: Remove go references #51682

Merged
merged 2 commits into from Dec 7, 2018
Merged

Conversation

@adisbladis
Copy link
Member

adisbladis commented Dec 7, 2018

Motivation for this change

This drastically reduces the closure size for the kubernetes service

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

adisbladis added 2 commits Dec 7, 2018
@adisbladis

This comment has been minimized.

Copy link
Member Author

adisbladis commented Dec 7, 2018

@GrahamcOfBorg test kubernetes.rbac.singlenode kubernetes.dns.singlenode kubernetes.rbac.multinode kubernetes.dns.multinode

@adisbladis adisbladis merged commit 7574d4e into NixOS:master Dec 7, 2018
14 checks passed
14 checks passed
nix-build -A cni -A cni-plugins --argstr system aarch64-linux Build Results
Details
nix-build -A cni -A cni-plugins --argstr system x86_64-darwin Build Results
Details
nix-build -A tests.kubernetes.dns.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.rbac.singlenode --argstr system aarch64-linux Build Results
Details
nix-build -A tests.kubernetes.dns.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.rbac.singlenode --argstr system x86_64-linux Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A cni -A cni-plugins --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.