Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net_snmp: 5.7.3 -> 5.8 #51683

Closed
wants to merge 2 commits into from
Closed

net_snmp: 5.7.3 -> 5.8 #51683

wants to merge 2 commits into from

Conversation

@cyounkins
Copy link
Contributor

cyounkins commented Dec 7, 2018

Motivation for this change

Fixes #51459 #48099

Wasn't able to get the perl modules working, but I may revisit it after this is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cyounkins

This comment has been minimized.

Copy link
Contributor Author

cyounkins commented Dec 14, 2018

@wkennington Could you review?

@cyounkins

This comment has been minimized.

Copy link
Contributor Author

cyounkins commented Dec 17, 2018

@peterhoeg could you review/test?

@matthewbauer

This comment has been minimized.

Copy link
Member

matthewbauer commented Dec 19, 2018

@GrahamcOfBorg build net_snmp

@cyounkins

This comment has been minimized.

Copy link
Contributor Author

cyounkins commented Dec 26, 2018

Good to go?

@peterhoeg

This comment has been minimized.

Copy link
Member

peterhoeg commented Dec 26, 2018

@cyounkins, really appreciate the PR but haven't had the time to take a look.

@peterhoeg

This comment has been minimized.

Copy link
Member

peterhoeg commented Dec 26, 2018

Cc @volth as resident perl guru.

@Mic92 Mic92 mentioned this pull request Jan 26, 2019
0 of 10 tasks complete
@Ekleog

This comment has been minimized.

Copy link
Member

Ekleog commented Mar 8, 2019

This has now been merged once rebased, in #54616.

@Ekleog Ekleog closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.